Summary: | [Gmic] Bug in the preview of filters | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | David REVOY <info> |
Component: | G'Mic for Krita | Assignee: | amyspark <amy> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | amy |
Priority: | NOR | ||
Version: | 5.0.0-beta1 | ||
Target Milestone: | --- | ||
Platform: | Appimage | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/3901afa9f1b388b15a0b61f100e9d87a0ffe9e87 | Version Fixed In: |
Description
David REVOY
2021-09-27 13:58:42 UTC
@amyspark: Here is the test you adviced on IRC: I can reproduce the bug on krita-5.0.0-beta1-0c28050-x86_64.appimage (fresh 5.0 beta plus, Gmic 2.9.9) but it is less frequent (I need to load the filter and switch between a couple of filter to trigger the empty preview). Something weird: I can't make krita-5.1.0-prealpha-3e23fc2-x86_64.appimage to bug the same way. It is robust on it. Hi David! I've been able to confirm it works as "expected". I implemented all of GMic's available layer modes, and the filter stdlib says the default for "Boost Chromaticity" is "NoInput". In layperson's terms, the default value for this filter's Input layers is "None". Can you confirm that pressing the little refresh button beside the Input Layers selector does fix this issue? > I implemented all of GMic's available layer modes
I didn't say that this mode isn't available in 4.4.8, only in the v5 plugin, this is why the issue hadn't arisen before.
I confirm: the layer has "None" and refreshing the Input/Output (or setting manually the Input Layer to "Active (default)" fixes it. Fixed in https://github.com/amyspark/gmic/commit/5ef15eb73418f367217b7d520dedffa716db8dbc. It'll be rolled up in the next beta. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1077 Git commit 25a238912175837a29586fab58a414b46c8614de by L. E. Segovia. Committed on 04/10/2021 at 14:19. Pushed by dkazakov into branch 'krita/5.0'. GMIC: update to 2.9.9 patch 2 M +2 -2 3rdparty/ext_gmic/CMakeLists.txt M +2 -2 3rdparty_plugins/ext_gmic/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/25a238912175837a29586fab58a414b46c8614de Git commit 3901afa9f1b388b15a0b61f100e9d87a0ffe9e87 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 04/10/2021 at 14:39. Pushed by dkazakov into branch 'master'. GMIC: update to 2.9.9 patch 2 M +2 -2 3rdparty/ext_gmic/CMakeLists.txt M +2 -2 3rdparty_plugins/ext_gmic/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/3901afa9f1b388b15a0b61f100e9d87a0ffe9e87 I confirm the fix: I can't reproduce on krita-5.0.0-beta2-x86_64.appimage with 2.9.9 Gmic. Thank you @amyspark ! :-) |