Bug 442176

Summary: Sort menu dropdowns have no labels at the recently/frequently played views
Product: [Applications] Elisa Reporter: Nagy Tibor <xnagytibor>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version: 21.08.1   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 21.12.2
Attachments: Screenshot

Description Nagy Tibor 2021-09-08 13:49:46 UTC
Created attachment 141390 [details]
Screenshot

SUMMARY
The sort menu dropdowns at the "Recently Played" and "Frequently Played" views have no labels next to the menu item checkboxes. Only these two views are affected, the other views with sorting support doesn't have this issue ("Albums", "Artists", "Tracks", "Genres", "Files").

Thankfully sorting still works at those views regardless the missing labels.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.22
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.3
Comment 1 Nagy Tibor 2021-09-08 14:08:48 UTC
Also just noticed the checkboxes in those dropdowns are also wrong, they should have been radio buttons. Sorting orders are mutually exclusive options. Should I file a separate ticket for this?
Comment 2 Nate Graham 2021-09-09 16:19:54 UTC
lol that's true.

Yes, separate ticket for radio buttons would be nice.
Comment 3 Nagy Tibor 2021-09-09 16:37:11 UTC
Radio button ticket: Bug 442234
Comment 4 Bug Janitor Service 2023-01-09 17:00:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/406
Comment 5 Bug Janitor Service 2023-01-10 16:24:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/407
Comment 6 Nate Graham 2023-01-10 22:09:21 UTC
Git commit f449f49aca4188f09dbb3d9aab69e97783ddcee3 by Nate Graham, on behalf of Jack Hill.
Committed on 10/01/2023 at 22:09.
Pushed by ngraham into branch 'master'.

Fix Recently and Frequently Played sort buttons

The sortRole for both views were being changed to TitleRole, since each
view is track-based (i.e. they display tracks, as opposed to albums,
artists, etc.). I think the function responsible for this exists for
future purposes when users will be able to switch between grid/list
views manually.

Solution to is to just hardcode the sortRole and sortOrder of each view.
This also fixes the problem where the sort menu had no text.

Note that the sorting for "Frequently Played" currently does sort purely
based on each tracks' play count. This will be addressed elsewhere.
FIXED-IN: 21.12.2

M  +25   -6    src/viewmanager.cpp
M  +2    -2    src/viewmanager.h

https://invent.kde.org/multimedia/elisa/commit/f449f49aca4188f09dbb3d9aab69e97783ddcee3
Comment 7 Nate Graham 2023-01-11 22:41:32 UTC
Git commit f47edcc1bf4a0483a679f58595a71814b6b19182 by Nate Graham, on behalf of Jack Hill.
Committed on 11/01/2023 at 22:41.
Pushed by ngraham into branch 'release/21.12'.

Fix Recently and Frequently Played sort buttons

The sortRole for both views were being changed to TitleRole, since each
view is track-based (i.e. they display tracks, as opposed to albums,
artists, etc.). I think the function responsible for this exists for
future purposes when users will be able to switch between grid/list
views manually.

Solution to is to just hardcode the sortRole and sortOrder of each view.
This also fixes the problem where the sort menu had no text.

Note that the sorting for "Frequently Played" currently does sort purely
based on each tracks' play count. This will be addressed elsewhere.
FIXED-IN: 21.12.2


(cherry picked from commit f449f49aca4188f09dbb3d9aab69e97783ddcee3)

M  +25   -6    src/viewmanager.cpp
M  +2    -2    src/viewmanager.h

https://invent.kde.org/multimedia/elisa/commit/f47edcc1bf4a0483a679f58595a71814b6b19182
Comment 8 Nate Graham 2023-01-12 21:02:01 UTC
Git commit 1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b by Nate Graham, on behalf of Jack Hill.
Committed on 12/01/2023 at 21:01.
Pushed by ngraham into branch 'release/22.12'.

Fix Recently and Frequently Played sort buttons

The sortRole for both views were being changed to TitleRole, since each
view is track-based (i.e. they display tracks, as opposed to albums,
artists, etc.). I think the function responsible for this exists for
future purposes when users will be able to switch between grid/list
views manually.

Solution to is to just hardcode the sortRole and sortOrder of each view.
This also fixes the problem where the sort menu had no text.

Note that the sorting for "Frequently Played" currently does sort purely
based on each tracks' play count. This will be addressed elsewhere.
FIXED-IN: 21.12.2


(cherry picked from commit f449f49aca4188f09dbb3d9aab69e97783ddcee3)

M  +25   -6    src/viewmanager.cpp
M  +2    -2    src/viewmanager.h

https://invent.kde.org/multimedia/elisa/commit/1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b