| Summary: | Single finger panning gesture stops when dragging quickly | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | Usability | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/93111de94474fbd94b4718737f02611eb8554054 | Version Fixed In: | |
| Attachments: | Tablet log for single touch point panning where panning stopped mid-gesture | ||
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1029 Git commit f6c204f5f93617610edf9716d4741de0bd25e6cc by Alvin Wong. Committed on 05/09/2021 at 12:14. Pushed by alvinwong into branch 'master'. Fix touch pan gesture stopping when moving quickly The code before this change ignores large movements to prevent canvas from jumping at the end of a 3-finger gesture, which also blocks fast panning. This removes the movement delta check in favour of checking the number of touch points, so that fast movements will no longer interrupts the pan gesture. M +19 -10 libs/ui/input/kis_pan_action.cpp https://invent.kde.org/graphics/krita/commit/f6c204f5f93617610edf9716d4741de0bd25e6cc Git commit 93111de94474fbd94b4718737f02611eb8554054 by Alvin Wong. Committed on 05/09/2021 at 12:26. Pushed by alvinwong into branch 'krita/5.0'. Fix touch pan gesture stopping when moving quickly The code before this change ignores large movements to prevent canvas from jumping at the end of a 3-finger gesture, which also blocks fast panning. This removes the movement delta check in favour of checking the number of touch points, so that fast movements will no longer interrupts the pan gesture. (cherry picked from commit f6c204f5f93617610edf9716d4741de0bd25e6cc) M +19 -10 libs/ui/input/kis_pan_action.cpp https://invent.kde.org/graphics/krita/commit/93111de94474fbd94b4718737f02611eb8554054 |
Created attachment 141121 [details] Tablet log for single touch point panning where panning stopped mid-gesture SUMMARY The single finger panning gesture stops mid-gesture if the movement is too quick. STEPS TO REPRODUCE 1. Disable touch painting 2. Pan with single touch 3. Increase touch movement speed OBSERVED RESULT Gesture stops when touch point moves quick enough. EXPECTED RESULT Gesture shall not stop no matter how fast the gesture is. SOFTWARE/OS VERSIONS Windows: 10 20H1 ADDITIONAL INFORMATION On Surface Pro 2017 Nightly 6ce9aadc4b