| Summary: | Valgrind ppc64/tests/Makefile.am fixups | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Will Schmidt <will_schmidt> |
| Component: | general | Assignee: | Carl Love <cel> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | cel, jseward, will_schmidt |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | proposed patch for none/tests/ppc64/Makefile.am | ||
Issues were addressed in commit: commit 81032a82f77fc7038d80621fefd75b5726760a60 Author: Carl Love <cel@us.ibm.com> Date: Fri Sep 10 16:20:10 2021 -0500 Cleanup of none/tests/ppc64/Makefile.am Fixing indentation and move the jm_insns_CFLAGS next to the other CFLAGS definitions. No functional changes. |
Created attachment 140611 [details] proposed patch for none/tests/ppc64/Makefile.am SUMMARY Correct some issues as reported with none/tests/ppc64/Makefile.am. In particular, -The wrong mcpu string is used for BUILD_FLAGS_ISA_3_00 -Indentation (tab/whitespace) glitch in EXTRA_DIST definition. -Move jm_insn_CFLAGS definition to be near other CFLAGS defines. proposed patch attached. STEPS TO REPRODUCE 1. build and run valgrind tests on a power9 target 2. observe tests being built with a mcpu=power9 cflags. 3. OBSERVED RESULT EXPECTED RESULT victory. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION