| Summary: | Enabling Reboot to UEFI shouldn't trigger "Unsaved changes" when closing the KCM | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Ilya Bizyaev <bizyaev> |
| Component: | kcm_smserver | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | nate, waynejwoww |
| Priority: | NOR | ||
| Version First Reported In: | 6.0.4 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Ilya Bizyaev
2021-08-01 12:56:44 UTC
Confirmed. Manually adding `kcm.needsSave = false;` into the checkbox's onToggled: signal handles has no effect. Basically the bug is that this one setting is using the Instant Apply paradigm, but the rest of the page uses the Explicit Apply paradigm and isn't aware that it shouldn't prompt to apply or discard for just this one checkbox. The problem still persists. When you check the "Enter UEFI setup screen"-checkbox, a banner with a "Restart Now" button appears on the top of the settings page, which is generally a good idea. The problem is, however, even when clicking this "Restart Now" button, the "Apply Settings"-prompt still appears. I have a better solution for the whole situation: Just make a "Restart now and enter the UEFI screen" button next to the checkbox always visible (i.e. the button should be visible without checking the box first). While I get that there are situations when someone wants to enter the UEFI the next boot (but not immediately!), I think in most cases one wants to actually restart and enter the UEFI immediately (!). With my suggestion both use cases are covered, while saving the one who wants to restart and enter the UEFI immediately is spared at least 2 clicks. |