Summary: | Two options for changing the visibility of the menu bar | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | popov895 <popov895> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, popov895 |
Priority: | NOR | ||
Version: | 21.07.80 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=439516 | ||
Latest Commit: | https://invent.kde.org/utilities/konsole/commit/5fc0c180f1efb90d819c69f9eb3575eb49dcfdf7 | Version Fixed In: | 21.12 |
Description
popov895
2021-07-27 13:22:12 UTC
Given that the one in the settings window is not profile-specific, I am inclined to agree. The one in the configuration window should be removed, and the one in the Settings menu should be remembered across launches, just like in other KDE apps. And we should also implement KHamburgerMenu for Konsole when the menubar is hidden. :) A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/446 Git commit 5fc0c180f1efb90d819c69f9eb3575eb49dcfdf7 by Kurt Hindenburg, on behalf of Eugene Popov. Committed on 20/09/2021 at 18:54. Pushed by hindenburg into branch 'master'. Use one option to control menubar visibility Currently there are two options to control menubar visibility: the first in the menu and the second in the preferences dialog, moreover the second option makes the changes persistent. This MR removes the second option (from the preferences dialog) and makes the first option (from the menu) make the changes persistent. M +14 -13 src/MainWindow.cpp M +7 -5 src/MainWindow.h M +0 -2 src/settings/GeneralSettings.cpp M +69 -95 src/settings/GeneralSettings.ui M +0 -10 src/settings/konsole.kcfg https://invent.kde.org/utilities/konsole/commit/5fc0c180f1efb90d819c69f9eb3575eb49dcfdf7 |