| Summary: | After Blue Ocean changes, Dockable Panel / MDI buttons no longer have a hover highlight | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Paul McAuley <kde> |
| Component: | QStyle | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, kde, nate, noahadvs, uhhadd |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=438964 | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/commit/386b12d3bfaef878dd95ac5dd7d13a0560fb3d73 | Version Fixed/Implemented In: | 5.24.3 |
| Sentry Crash Report: | |||
| Attachments: | For example, the restore/undock button here in KDevelop used to show a highlighted background when moused over: | ||
*** Bug 438964 has been marked as a duplicate of this bug. *** I have isolated this regression to commit: 8de82c4d508510a9f6a633d820fba1303c5d129a Make buttons styled like Blue Ocean mockups (In reply to Paul McAuley from comment #2) > I have isolated this regression to commit: > > 8de82c4d508510a9f6a633d820fba1303c5d129a Make buttons styled like Blue Ocean > mockups https://invent.kde.org/plasma/breeze/-/commit/8de82c4d508510a9f6a633d820fba1303c5d129a (In reply to Paul McAuley from comment #3) > https://invent.kde.org/plasma/breeze/-/commit/ > 8de82c4d508510a9f6a633d820fba1303c5d129a I left a comment at the link above. I have pinpointed this further to the function: bool Style::drawToolButtonLabelControl( const QStyleOption* option, QPainter* painter, const QWidget* widget ) const Restoring the following lines restores the previous hover behaviour in docks: else if( (!flat && hasFocus) || (flat && (state & State_Sunken) && !mouseOver) ) iconMode = QIcon::Selected; else if( mouseOver && flat ) iconMode = QIcon::Active; Deleting similar hover logic is done in 3 other places in this commit, so I'm not sure if there are any other side-effects caused by that commit. I would need to know what cblack's thinking was in deleting the hover logic. I see that animation logic has also been deleted. Jan, can you please investigate? Thanks. A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/192 Git commit 386b12d3bfaef878dd95ac5dd7d13a0560fb3d73 by Nate Graham, on behalf of Jan Blackquill. Committed on 06/03/2022 at 17:41. Pushed by ngraham into branch 'master'. kstyle: fix dock title toolbar buttons not indicating selected/active state FIXED-IN: 5.24.3 M +2 -0 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/386b12d3bfaef878dd95ac5dd7d13a0560fb3d73 |
Created attachment 140303 [details] For example, the restore/undock button here in KDevelop used to show a highlighted background when moused over: KDE Neon Unstable 5.22.80. After Blue Ocean changes, a regression has been introduced whereby Dockable Panel / MDI buttons no longer have a hover highlight on mouse-over.