Bug 439700

Summary: Loop in Color Sampler
Product: [Applications] krita Reporter: Tiar <tamtamy.tymona>
Component: Resource ManagementAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED NOT A BUG    
Severity: normal CC: halla
Priority: NOR Keywords: regression, release_blocker
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Tiar 2021-07-09 22:22:21 UTC 
SUMMARY
I'm not sure what the impact is for the user, but I noticed it in the code so it needs to be checked.

There is a loop in palettes if the user uses both 1) a palette inside a document, 2) a color sampler to add new colors to the palette.
The loop is as follows:
Color Sampler updates the palette in the resource server, palette editor notices it by slotSetDocumentModified(), and that updates the palette in the resource server again, potentially triggering another slotSetDocumentModified() etc.

I haven't tested it so I don't know how it looks from the user perspective but it might lead to a freeze.

SOFTWARE/OS VERSIONS
git hash: 13f04ca236
Comment 1 Halla Rempt 2021-07-27 12:58:42 UTC 
I've tested this and I haven't seen any problems. It just works.