Bug 439175

Summary:	Make QtWebkitWidgets optional / remove the dependency
Product:	[Applications] cantor	Reporter:	Luca Beltrame <lbeltrame>
Component:	general	Assignee:	Alexander Semke <alexander.semke>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexander.semke
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/education/cantor/commit/ea56d70e0857f72aa25c9abb6f29f0a62857d27d	Version Fixed/Implemented In:	21.08
Sentry Crash Report:

Description Luca Beltrame 2021-06-26 09:18:57 UTC

The recent merging of the documentation branch in cantor (master) added both a dependency on QWebEngine and QtWebKitWidgets.

The latter is part of the unmaintained and unsupported QtWebKit (save for a third party fork not everyone ships), which some distributions are removing. 

Thus, the dependency on QtWebKitWidgets (which looks unused from a quick glance in the code, but I might be mistaken) should be either removed entirely (if unused) or made optional (if used) to allow also building on distributions which do not ship, or plan to not ship QtWebKit anymore (such as openSUSE).

Comment 1 Alexander Semke 2021-06-26 10:56:44 UTC

Git commit ea56d70e0857f72aa25c9abb6f29f0a62857d27d by Alexander Semke.
Committed on 26/06/2021 at 10:56.
Pushed by asemke into branch 'master'.

Removed the dependency on QtWebkitWidgets and on some other libraries in the new documentation panel code.
FIXED-IN: 21.08

M  +0    -1    CMakeLists.txt
M  +0    -5    src/panelplugins/documentationpanel/CMakeLists.txt

https://invent.kde.org/education/cantor/commit/ea56d70e0857f72aa25c9abb6f29f0a62857d27d

Comment 2 Alexander Semke 2021-06-26 10:58:02 UTC

(In reply to Luca Beltrame from comment #0)
> The recent merging of the documentation branch in cantor (master) added both
> a dependency on QWebEngine and QtWebKitWidgets.
I removed this dependency now. Thanks for pointing this out!