| Summary: | Move keyframes to negative position crash krita | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | grum999 |
| Component: | Animation | Assignee: | Eoin O'Neill <eoinoneill1991> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | emmetoneill.pdx |
| Priority: | NOR | Keywords: | release_blocker |
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Example of crash | ||
When crashed, this message is printed in terminal: ASSERT (krita): "time >= 0" in file /home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/kis_keyframe_channel.cpp, line 97 Ahh, that's a funny one. :) Good find! (Also I want to thank you for sharing the videos. It's super helpful.) (In reply to Emmet O'Neill from comment #3) > (Also I want to thank you for sharing the videos. It's super helpful.) Writing process to reproduce a bug is sometimes difficult. Videos are an easy way to provide an explanation; even if i forgot something in description, you can literally see what is made, in which condition ;-) Grum999 Git commit c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 by Eoin O'Neill. Committed on 18/06/2021 at 01:49. Pushed by eoinoneill into branch 'master'. KisAnimTimelineFrames: Moving keys no longer allows for movement to negative values. M +15 -1 plugins/dockers/animation/KisAnimTimelineFramesModel.cpp https://invent.kde.org/graphics/krita/commit/c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 (In reply to Eoin O'Neill from comment #5) > Git commit c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 by Eoin O'Neill. > Committed on 18/06/2021 at 01:49. I can confirm problem is fixed :) Grum999 |
Created attachment 139413 [details] Example of crash SUMMARY STEPS TO REPRODUCE 1. Create an animation 2. Select keyframes 3. Move it OBSERVED RESULT When moved to: - positive position=OK - negative position=Crash (segmentation fault) EXPECTED RESULT Do not crash :) In this case a negative position must be forced to be at frame 0 SOFTWARE/OS VERSIONS krita-5.0.0-prealpha-949e869-x86_64.appimage