Bug 438766

Summary:	Animation curves - Transform Mask - New keyframe between 2 keyframes + CTRL Z
Product:	[Applications] krita	Reporter:	grum999
Component:	Animation	Assignee:	Eoin O'Neill <eoinoneill1991>
Status:	RESOLVED FIXED
Severity:	normal	CC:	emmetoneill.pdx, eoinoneill1991
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/ec7d311c7e51542b694654e47514ed007f609993	Version Fixed In:
Sentry Crash Report:
Attachments:	example of problem

Description grum999 2021-06-16 19:32:26 UTC

Created attachment 139410 [details]
example of problem

SUMMARY

Not sure if related to https://bugs.kde.org/show_bug.cgi?id=438341
So I prefer to create a new bug 


STEPS TO REPRODUCE
1. Create a paint layer with a rectangle
2. Add a transform mask on paint layer
3. Create some keyframes in animation curves
4. Start to navigate between keyframe
5. Click on "insert keyframe" (not sure about button name)


OBSERVED RESULT
(A) A new keyframe is created, but with wrong value (not related to zoom here!)


(B) To undo action, we have to execute UNDO action (CTRL+Z) 9 times (one per transform mask property)



EXPECTED RESULT
(A) When inserting a new keyframe, properties have to be properly interpolated

(B) Only one CTRL+Z should be needed to undo action



SOFTWARE/OS VERSIONS
krita-5.0.0-prealpha-949e869-x86_64.appimage

Comment 1 Emmet O'Neill 2021-06-17 00:28:44 UTC

Yeah, that should be grouped into a single undo command for sure.
Thanks!

Comment 2 Eoin O'Neill 2021-06-17 01:26:14 UTC

Git commit ec7d311c7e51542b694654e47514ed007f609993 by Eoin O'Neill.
Committed on 17/06/2021 at 01:23.
Pushed by eoinoneill into branch 'master'.

KisAnimCurvesDocker: Fix add keyframe / remove keyframe buttons undo stack.

Originally, they were adding all keyframes as their own undo operation,
causing undo spam. They now correctly group all keyframe additions and
removals to one undo object.

M  +47   -43   plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +6    -1    plugins/dockers/animation/KisAnimCurvesDocker.h

https://invent.kde.org/graphics/krita/commit/ec7d311c7e51542b694654e47514ed007f609993

Comment 3 grum999 2021-06-17 11:26:57 UTC

I'll try to test it tonight...

But commit is only for CTRL+Z?
Or it takes in account case (A) too?  
(I tried to look in code but... I'm not sure ^_^")


Grum999

Comment 4 grum999 2021-06-19 15:29:29 UTC

(In reply to Eoin O'Neill from comment #2)
> Git commit ec7d311c7e51542b694654e47514ed007f609993 by Eoin O'Neill.
> Committed on 17/06/2021 at 01:23.
> Pushed by eoinoneill into branch 'master'.
I confirm problem (B) about CTRL+Z is fixed
I'll create a new dedicated bug about problem (A)


Grum999