| Summary: | Domain name quickgit.kde.org does not exist | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Christopher Yeleighton <giecrilj> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | CLOSED WORKSFORME | ||
| Severity: | normal | CC: | aleixpol, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.22.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| URL: | https://quickgit.kde.org/?p=discover.git | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Christopher Yeleighton
2021-06-13 15:59:44 UTC
The wrong URL is taken from RPM. Discover should specify it explicitly in metainfo. Here is a good one: <URL: https://apps.kde.org/discover/ >. Discover's AppStream data is clean, and shows https://invent.kde.org/plasma/discover. So this old URL must be coming from your distro's out of date packaging. I would report this to them. (In reply to Nate Graham from comment #2) > Discover's AppStream data is clean, and shows > https://invent.kde.org/plasma/discover. So this old URL must be coming from > your distro's out of date packaging. I would report this to them. So I have. But Discover's AppStream data is also clean of mentioning some home page form Discover and that is bad. We should not rely on RPM to provide the correct URL, we should provide one ourselves. See also <URL: https://invent.kde.org/plasma/discover/-/merge_requests/136 >. Being a newbie, I cannot tell whether it is right or wrong; I am currently trying to build this thing to see whether anything I did is totally off. I need the right builder image though and it may take a lot of steps (and failures) to get it right. So what we do rely on is the metainfo generator parsing the KAboutData as a source of truth, which it does do. :) The alternative is setting it manually which will lead to conflicting sources of truth and that's just the beginning of a maintenance headache. Please report this to your distro. The ultimate source of truth regarding what the URL is is us, not the downstream packager. As I said, I have reported it to the distro—but where is the distro packager supposed to get the right URL from if not from our metainfo? I have no idea what you are talking about. Discover doesn't list quickgit.kde.org. Are you maybe running an old version of Discover? In the end it's true, at some point quickgit.kde.org was a thing. Not anymore. (In reply to Aleix Pol from comment #7) > I have no idea what you are talking about. Discover doesn't list > quickgit.kde.org. Are you maybe running an old version of Discover? > > In the end it's true, at some point quickgit.kde.org was a thing. Not > anymore. Discover does not list any home page for itself, that is why distribution packagers get it wrong. |