| Summary: | [Requests] Make it default to use Stop Gradient instead of Segment Gradient | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Filters | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | ginoba |
| Priority: | NOR | ||
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/4b90f2b42d4bc9108f86a7019f69b29f1ae0085e | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
acc4commissions
2021-06-10 11:42:46 UTC
The only thing I can imagine you are refering to is that the gradient presets are segment gradients and you want them to be stop gradients... maybe? I don't know, you'll have to explain better. Oh, I see how it works now. I thought there was a default setting of Gradient since it was set to Segment Gradient every time I open the gradient filter window. But that was because the gradient preset(Foreground to Background) uses that method, not Krita. Changing it to resolved. Could you make the preset loaded in Gradient filter follows what you selected atm in fill gradient in Toolbar then? I can look into that. (In reply to acc4commissions from comment #3) > Could you make the preset loaded in Gradient filter follows what you > selected atm in fill gradient in Toolbar then? But I don't think this is any urgent tho. This could be in the last of the last of the priority list. (In reply to acc4commissions from comment #3) > Could you make the preset loaded in Gradient filter follows what you > selected atm in fill gradient in Toolbar then? It was just a thought and if making this possible complicates the code or make the structure inconsistant or does anything of that sort, I'm find with not having it at all. > It was just a thought and if making this possible complicates the code or
> make the structure inconsistant or does anything of that sort, I'm find with
> not having it at all.
*find -> fine
I already made a patch: https://invent.kde.org/graphics/krita/-/merge_requests/903 * When opening for the first time the fill layer or filter it selects the currently active global gradient. * Once you close the dialog the gradient in it is stored and loaded when you reopen it, it won't reload the global gradient. * If you change the global gradient it doesn't affect already created fill layers or gradient map filters. Git commit 4b90f2b42d4bc9108f86a7019f69b29f1ae0085e by Dmitry Kazakov, on behalf of Deif Lou. Committed on 13/06/2021 at 06:10. Pushed by dkazakov into branch 'master'. Make gradient fill layer and gradient map default to the currently selected global gradient M +11 -1 plugins/filters/gradientmap/KisGradientMapFilterConfigWidget.cpp M +3 -3 plugins/filters/gradientmap/KisGradientMapFilterConfiguration.cpp M +1 -1 plugins/filters/gradientmap/KisGradientMapFilterConfiguration.h M +11 -1 plugins/generators/gradient/KisGradientGeneratorConfigWidget.cpp M +3 -3 plugins/generators/gradient/KisGradientGeneratorConfiguration.cpp M +1 -1 plugins/generators/gradient/KisGradientGeneratorConfiguration.h https://invent.kde.org/graphics/krita/commit/4b90f2b42d4bc9108f86a7019f69b29f1ae0085e tbh I bit regret suggesting this since it was a very tiny issue. I hope it won't cause maintenance problems in the future. |