| Summary: | Notifications use the application theme's link colour | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Riccardo Robecchi <sephiroth_pk> |
| Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.22.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/7c1f57c5d509e3069e344dfa5392a04d690e4618 | Version Fixed In: | 5.22.4 |
| Attachments: |
Screenshot of the issue
Breeze Light plasma theme and honeycomb color scheme |
||
Which exact Plasma theme are you using? Have you verified that it has a more appropriate link color internally? Created attachment 139182 [details]
Breeze Light plasma theme and honeycomb color scheme
Related: https://bugreports.qt.io/browse/QTBUG-81463 TextEdit has no way to change link color but text does I believe a TextEdit is being used to make the text selectable. (In reply to Nate Graham from comment #4) > I believe a TextEdit is being used to make the text selectable. That's correct :) A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/941 Git commit a3734c74f843e37625783fce14ccbe7e69213d66 by Nate Graham, on behalf of Kai Uwe Broulik. Committed on 22/07/2021 at 18:37. Pushed by ngraham into branch 'master'. [Notifications] Set Plasma linkColor on notification label There's no API to set `linkColor` on `TextEdit` and it would use the system link color potentially clashing with the Plasma theme. FIXED-IN: 5.22.3 M +6 -1 applets/notifications/package/contents/ui/NotificationItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/a3734c74f843e37625783fce14ccbe7e69213d66 Git commit 7c1f57c5d509e3069e344dfa5392a04d690e4618 by Nate Graham, on behalf of Kai Uwe Broulik. Committed on 22/07/2021 at 18:45. Pushed by ngraham into branch 'Plasma/5.22'. [Notifications] Set Plasma linkColor on notification label There's no API to set `linkColor` on `TextEdit` and it would use the system link color potentially clashing with the Plasma theme. FIXED-IN: 5.22.3 (cherry picked from commit a3734c74f843e37625783fce14ccbe7e69213d66) M +6 -1 applets/notifications/package/contents/ui/NotificationItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/7c1f57c5d509e3069e344dfa5392a04d690e4618 |
Created attachment 139171 [details] Screenshot of the issue SUMMARY Notifications appear to use the application theme's colour for links, instead of using the Plasma theme's colour. This causes links to be unreadable when a dark Plasma theme and a light application theme are used. STEPS TO REPRODUCE 1. Set a dark Plasma theme and a light application theme. 2. Copy some files. OBSERVED RESULT The link in the notification uses the application theme's colour and is nigh unreadable. EXPECTED RESULT The link uses the Plasma theme colour and is readable. SOFTWARE/OS VERSIONS Linux: KDE neon KDE Plasma Version: 5.22.0 KDE Frameworks Version: 5.82.0 Qt Version: 5.15.2 ADDITIONAL INFORMATION