Summary: | Vertical separator between columns in widescreen view differs in color from the separator between the sidebar and then KCM | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Lua <lv215bd5> |
Component: | sidebarview | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | me, med.medin.2014, nate, plasma-bugs |
Priority: | NOR | ||
Version: | 5.22.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/systemsettings/-/commit/18f3fc7d10b43788008486ae3d48704a147a537d | Version Fixed In: | 6.0 |
Attachments: | Separators |
Also, there is an inconsistency with the text spacement. The "Colors" and "Appearance" have different spacements from the separators. One issue per bug report please. *** Bug 440550 has been marked as a duplicate of this bug. *** https://invent.kde.org/frameworks/kirigami/-/merge_requests/903 changes this, but doesn't quiiiiite fix it. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1455 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1457 Git commit 21de419ea73054589cf4ab90a8e0df5b24d8c546 by Akseli Lahtinen. Committed on 02/02/2024 at 11:25. Pushed by akselmo into branch 'master'. Use header color instead of window for columnview separator This makes the header separator colors match | Before | After | | ------ | ------ | | ![image](/uploads/817fe69ec3376d3ee49355653356c0c4/image.png) | ![image](/uploads/0ee2de1348ab0e3c1ec5d8a8142a8b5d/image.png) | M +2 -2 src/columnview.cpp https://invent.kde.org/frameworks/kirigami/-/commit/21de419ea73054589cf4ab90a8e0df5b24d8c546 Git commit a8e4348437df7edc4f07450dedffa8c34478a4dc by Marco Martin. Committed on 02/02/2024 at 11:29. Pushed by mart into branch 'master'. Use Header color set on overlaydrawer match colors on sidebar separators of Drawer as well M +2 -0 src/controls/OverlayDrawer.qml https://invent.kde.org/frameworks/kirigami/-/commit/a8e4348437df7edc4f07450dedffa8c34478a4dc A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/362 A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/291 Git commit e30109e950eb8b7062b64970ad3ac727dd9e1e57 by Marco Martin. Committed on 02/02/2024 at 11:41. Pushed by mart into branch 'master'. Make sidebar drawer separators proper Separator As everywhere else, use a Kirigami.Separator and since is a column separator use the Header color set M +3 -0 org.kde.desktop/Drawer.qml https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/e30109e950eb8b7062b64970ad3ac727dd9e1e57 Git commit a19d6c66195720683b148324f62ac9d29eb1ee52 by Marco Martin. Committed on 02/02/2024 at 11:33. Pushed by mart into branch 'master'. Use Header color set for separators as with drawers and ColumnView Make the color of the column separator consistent everywhere M +2 -0 app/sidebar/qml/Main.qml https://invent.kde.org/plasma/systemsettings/-/commit/a19d6c66195720683b148324f62ac9d29eb1ee52 Git commit 18f3fc7d10b43788008486ae3d48704a147a537d by Marco Martin. Committed on 02/02/2024 at 12:27. Pushed by mart into branch 'Plasma/6.0'. Use Header color set for separators as with drawers and ColumnView Make the color of the column separator consistent everywhere M +2 -0 app/sidebar/qml/Main.qml https://invent.kde.org/plasma/systemsettings/-/commit/18f3fc7d10b43788008486ae3d48704a147a537d |
Created attachment 139040 [details] Separators SUMMARY STEPS TO REPRODUCE 1. Open System Settings. OBSERVED RESULT The line next to the home icon and the one next to the "Colors" text have different shades of grey. EXPECTED RESULT SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.22.80 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Kernel Version: 5.4.0-73-generic (64-bit) Graphics Platform: X11 Processors: 4 × Intel Core Processor (Skylake, IBRS) Memory: 3.8 GiB of RAM Graphics Processor: llvmpipe ADDITIONAL INFORMATION