| Summary: | digiKam 7.3 doesn't have a Translators tab in its About dialogue anymore | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Tyson Tan <tysontanx> |
| Component: | Usability-i18n | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 7.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/commit/7235cf4cb69f234c1b0549ccfba5077ce9e7536e | Version Fixed/Implemented In: | 7.3.0 |
| Sentry Crash Report: | |||
|
Description
Tyson Tan
2021-05-27 12:38:20 UTC
Hi, Yes, it's a framework issue, as digiKam use KF5 for this kind of feature Gilles Caulier Thanks. I have reported it to kxmlgui as well: https://bugs.kde.org/show_bug.cgi?id=437738 *** This bug has been marked as a duplicate of bug 437738 *** So it turned out it could be a digiKam bug after all. No other apps has this issue except Elisa/digiKam(7.3.0nightly)/Apper. Related discussion: https://bugs.kde.org/show_bug.cgi?id=437738#c15 Albert Astals Cid said: (For Elisa) That's an elisa bug, open a bug for them, they either need to use KMainWindow (or some class that inherits from it) or call setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"), i18nc("EMAIL OF TRANSLATORS", "Your emails")); manually on their KAboutData as stated in the KAboutData documentation (For digiKam) it works on the last official release both using appimage and not using appimage, if it doesn't work on the nightly, i'd say that is their bug and not a kxmlgui bug either. It seems that the strings for the translators' credit is now missing from the original source... The doc from KAboutData says that when using KMainWindow the translators are set automatically. I see in older digiKam AppImages that the translation tab is available. We haven't made any changes to the code on our part, I think. When I check KAboutData::translators() the list is empty. I guess that the translator involved is in the translation file. So I suspect the mistake there, I'll check out the current translation and look it up. Incidentally, a look at other programs (Dolphin, Konsole) shows that no translators are manually specified in the code here. Maik Bug 438093 opened. Maik Git commit 7235cf4cb69f234c1b0549ccfba5077ce9e7536e by Maik Qualmann. Committed on 05/06/2021 at 04:37. Pushed by mqualmann into branch 'master'. set translator for KAboutData manually Related: bug 438093 FIXED-IN: 7.3.0 M +3 -1 NEWS M +2 -0 core/app/main/main.cpp M +2 -0 core/showfoto/main/main.cpp https://invent.kde.org/graphics/digikam/commit/7235cf4cb69f234c1b0549ccfba5077ce9e7536e Thank you Maik! :D |