| Summary: | Dots on the new calendar widget are sometimes positioned wrong | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Riccardo Robecchi <sephiroth_pk> |
| Component: | components | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carl, nate, plasma-bugs |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.82.0 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/commit/11e2ae62baf87daf2135ce55d1ebfdf515969572 | Version Fixed In: | 5.85 |
| Attachments: |
Screenshot of the widget
tiny Widget with two calendars |
||
The color is not hardcoded; it respects your active color scheme, and this is working fine for me. The problem seems to be the positioning there. It seems that the new calendar design doesn't support as nicely small calendars ( see screenshot). I see two ways to fix it. * Don't make it possible for users to create tinny calendars * Don't display the events dots for tinny calendars Probably the second solution is the best. Created attachment 138547 [details]
tiny
Created attachment 138555 [details] Widget with two calendars (In reply to Nate Graham from comment #1) > The color is not hardcoded; it respects your active color scheme, and this > is working fine for me. The problem seems to be the positioning there. You are right. After reading your comment I did a few experiments and I understood what happens: the colour of the dot does not respect the colour scheme, it is the same as the calendar in KOrganizer, so that's why changing the theme did not lead to a change in the colour (and led me to conclude it was hardcoded). See attached screenshot for reference: I enabled a second calendar and its colour showed up, and changing its colour in KOrganizer also changed it in the widget. This doesn't mean that the issue is not there anyway, as the colours I use are perfectly distinguishable on light themes, but not on dark ones. Git commit 11e2ae62baf87daf2135ce55d1ebfdf515969572 by Nate Graham, on behalf of Carl Schwan. Committed on 18/07/2021 at 19:36. Pushed by ngraham into branch 'master'. Add a bit more contrast to event indicator in calendar Now make it darker on light theme and lighter on dark theme M +2 -1 src/declarativeimports/calendar/qml/DayDelegate.qml https://invent.kde.org/frameworks/plasma-framework/commit/11e2ae62baf87daf2135ce55d1ebfdf515969572 Let's see if that's good enough. Please re-open if you continue to see problems here once Frameworks 5.85 is released. Thanks! |
Created attachment 138485 [details] Screenshot of the widget SUMMARY The new dots introduced with Frameworks 5.82 are really hard to spot with a dark theme. It seems like the colour is hard coded, so it only really works with light themes. On my 14" notebook I can't see the dots unless I get ~30 cm from the screen, thus making the dots way less useful than the old triangles. Moreover, when using non-default calendar widgets (e.g. Event Calendar) the date is too big and ends up under the dots, making readability worse. STEPS TO REPRODUCE 1. Set a dark theme 2. Open a calendar widget OBSERVED RESULT The new dots have a hard-coded colour and position which are difficult to read. EXPECTED RESULT The dots follow the theme colours, are more readable with a dark theme and do not overlap the date. SOFTWARE/OS VERSIONS Linux: KDE neon KDE Plasma Version: 5.21.5 KDE Frameworks Version: 5.82.0 Qt Version: 5.15.2 ADDITIONAL INFORMATION