| Summary: | Whole system tray is highlighted with a blue line after enabling/disabling "Keep open" feature of active applet | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | System Tray widget | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | materka, nate |
| Priority: | NOR | ||
| Version: | 5.21.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 | Version Fixed In: | 5.22.0 |
| Sentry Crash Report: | |||
| Attachments: | screen recording | ||
Can reproduce, but maybe this is actually intentional? Konrad? (In reply to Nate Graham from comment #1) > Can reproduce, but maybe this is actually intentional? Konrad? This is unintentional. It must be corner case in another corner case that was fixed :/ I need to check it. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/876 Git commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64 by Nate Graham, on behalf of Konrad Materka. Committed on 24/05/2021 at 16:06. Pushed by ngraham into branch 'master'. [applets/systemtray] Fix highlight on applet pin Sometimes parent component on the applet is not fully updated - for example effectiveStatus is not yet read from the model. In such case it will have default value leading to undesired effect. Call all `updateHighlightedItem` in `Qt.callLater` so that it is called in next event loop. As a bonus it is called only once, which can improve performance. FIXED-IN: 5.22.0 M +6 -6 applets/systemtray/package/contents/ui/CurrentItemHighLight.qml https://invent.kde.org/plasma/plasma-workspace/commit/07b3b10de7d09b8918bd237cf0eca9d3fe868c64 Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on behalf of Konrad Materka. Committed on 24/05/2021 at 16:23. Pushed by ngraham into branch 'Plasma/5.22'. [applets/systemtray] Fix highlight on applet pin Sometimes parent component on the applet is not fully updated - for example effectiveStatus is not yet read from the model. In such case it will have default value leading to undesired effect. Call all `updateHighlightedItem` in `Qt.callLater` so that it is called in next event loop. As a bonus it is called only once, which can improve performance. FIXED-IN: 5.22.0 (cherry picked from commit 07b3b10de7d09b8918bd237cf0eca9d3fe868c64) M +6 -6 applets/systemtray/package/contents/ui/CurrentItemHighLight.qml https://invent.kde.org/plasma/plasma-workspace/commit/1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 (In reply to Nate Graham from comment #5) > Git commit 1ce09dcfcb78198c95a94bf4d6f75a49c2b77dc0 by Nate Graham, on > behalf of Konrad Materka. > Pushed by ngraham into branch 'Plasma/5.22'. Thank you, Nate! |
Created attachment 138425 [details] screen recording SUMMARY Title says it all. Please watch the attached screen recording. EXPECTED RESULT blue line of system tray should not change when we enable/disable "Keep open" feature. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.21.90 KDE Frameworks Version: 5.82.0 Qt Version: 5.15.2 Graphics Platform: X11