Bug 437099

Summary:	Changing the track rating is quite clumsy
Product:	[Applications] Elisa	Reporter:	akm <alexvkaam>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jamboarder, nate, putr4.s, stuart
Priority:	NOR	Keywords:	usability
Version:	21.04.0
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/elisa/commit/d69ad3c89f53decd7ada8a6cd6157df3b3064090	Version Fixed In:	21.12

Description akm 2021-05-14 15:51:12 UTC

SUMMARY

There are several places when you see the track rating in Elisa, the "playing now" or for example the About a track button/form but none of these allow you to change the rating, instead you need to go the click on change in the about a track form, scroll down and change it there

STEPS TO REPRODUCE
1. Start a track
2. Select Playing 
3. Try to change the rating (click on the stars)

OBSERVED RESULT

nothing happens

EXPECTED RESULT

To change the rating/stars (amarok behaviour)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Tumbleweed
KDE Frameworks 5.82.0
Qt 5.15.2 (gebouwd tegen 5.15.2)
Het xcb venstersysteem

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2021-05-18 20:41:44 UTC

Yeah, it is. We could stand to improve this.

Comment 2 Stuart Morgan 2021-06-18 09:58:07 UTC

This probably merits a separate ticket, but it should also read (and optionally write) the ratings from the file metadata/tags if present.

Comment 3 Nate Graham 2021-07-22 21:12:28 UTC

Partially fixed by Javier Goday with https://invent.kde.org/multimedia/elisa/-/commit/5646861317d65ae3883aa1235d53ac1160270b56 in current git master. More to come will hopefully fully fix it.

Comment 4 Bug Janitor Service 2021-08-09 21:16:36 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/273

Comment 5 Nate Graham 2021-08-12 17:51:05 UTC

Git commit d69ad3c89f53decd7ada8a6cd6157df3b3064090 by Nate Graham.
Committed on 12/08/2021 at 16:22.
Pushed by ngraham into branch 'master'.

Make track ratings editable inline

This commit makes ratings editable inline from the Now Playing page as
well as the Playlist items. For Playlist items, because there is not a
lot of horizontal space available, the stars only become editable when
you click on a new "Rate this track" button on the existing row of
inline buttons.
FIXED-IN: 21.12

M  +1    -0    src/qml/ContextView.qml
M  +4    -2    src/qml/MediaTrackMetadataDelegate.qml
M  +31   -2    src/qml/PlayListEntry.qml
M  +1    -0    src/qml/shared/BasePlayListDelegate.qml

https://invent.kde.org/multimedia/elisa/commit/d69ad3c89f53decd7ada8a6cd6157df3b3064090

Comment 6 Nate Graham 2021-10-08 15:41:20 UTC

*** Bug 443479 has been marked as a duplicate of this bug. ***