| Summary: | If a shortcut component is deleted while being viewed, its name sometimes becomes unreadable | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Kishore Gopalakrishnan <kishore96> |
| Component: | kcm_keys | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/1698d42f525049e2bfc402b52c0e4642060ba5b4 | Version Fixed/Implemented In: | 5.23 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot showing the issue | ||
Can confirm. This is because this list uses totally custom list items with coloration heuristics copied from elsewhere which are not quite in sync with the general stuff. It needs to be ported to use Kirigami.BasicListItem. I tried a few weeks ago but got stuck on the inability to keep the undo icon at full opacity in this state without it feeling hacky. Maybe I'll try again. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/460 Git commit a73ce76190d2ba08bf3c0f492e9f06a67beeceac by Nate Graham. Committed on 11/05/2021 at 22:56. Pushed by ngraham into branch 'master'. Add new fadeContent property to BasicListItem This new property can be used to make the main content of a BasicListitem have a disabled or de-emphasized look while preserving full opacity for any leading or trailing items. M +15 -3 src/controls/BasicListItem.qml https://invent.kde.org/frameworks/kirigami/commit/a73ce76190d2ba08bf3c0f492e9f06a67beeceac Git commit 1698d42f525049e2bfc402b52c0e4642060ba5b4 by Nate Graham. Committed on 13/05/2021 at 13:28. Pushed by ngraham into branch 'master'. [kcms/keys] Port sidebar list item to Kirigami.BasicListItem This commit ports the Shortcuts KCM's sidebar list items to use Kirigami.BasicListItem, which fixes a binding loops and some bugs related to incorrect colors caused by the custom content item, and gets rid of another bespoke list item implementation. The embedded hover ToolButtons are changed to regular Buttons to avoid losing their hover appearance entirely due to differences in BasicListItem's coloration semantics. The result has minor visual differences but is functionally the same. FIXED-IN: 5.23 M +25 -35 kcms/keys/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/commit/1698d42f525049e2bfc402b52c0e4642060ba5b4 |
Created attachment 138266 [details] Screenshot showing the issue SUMMARY When we delete all shortcuts for a component but do not apply the change, the name of the component in the sidebar is greyed out. However, in certain situations, the name becomes white (and thus impossible to read in the default theme) instead of being greyed out. STEPS TO REPRODUCE 1. Go to System Settings > shortcuts > shortcuts. 2. Click on an item (in the sidebar which shows categories Applications, System Services etc.) to show the corresponding shortcuts. 3. Click the dustbin icon near the name of the viewed component. 4. Hover over another item (but do not click it). OBSERVED RESULTS The name of the deleted item is invisible, but the icon is shown greyed out (see attached image) EXPECTED RESULTS Name of the deleted item should be also be shown greyed out. SOFTWARE/OS VERSIONS System Settings version: 5.21.5 (couldn't find this in the list of versions) Operating System: Arch Linux KDE Plasma Version: 5.21.5 KDE Frameworks Version: 5.81.0 Qt Version: 5.15.2 Kernel Version: 5.12.1-arch1-1 OS Type: 64-bit Graphics Platform: X11 Graphics Processor: AMD Radeon™ Vega 8 Graphics ADDITIONAL INFORMATION