| Summary: | Honor EXIF image orientation metadata when adding images | ||
|---|---|---|---|
| Product: | [Applications] tellico | Reporter: | Robby Stephenson <robby> |
| Component: | general | Assignee: | Robby Stephenson <robby> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 3.4 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/office/tellico/commit/ae5202f8868c3816bdaef78526865c972f4f4b74 | Version Fixed In: | 3.4.1 |
| Sentry Crash Report: | |||
|
Description
Robby Stephenson
2021-05-06 11:28:26 UTC
Git commit ae5202f8868c3816bdaef78526865c972f4f4b74 by Robby Stephenson. Committed on 06/05/2021 at 11:29. Pushed by rstephenson into branch '3.4'. Use QImageReader to account for image orientation metadata Inside the QImage constructor, use QImageReader explicitly and set autoTransform(). Add a unit test. Benchmarks seems to say this loading approach may even be slightly faster than before. Since the QImage:load() method uses QImageReader internally as well, I don't believe there would be a downside to creating a new QImageReader every time. FIXED-IN: 3.4.1 M +10 -5 src/images/image.cpp A +- -- src/tests/data/img1.jpg A +- -- src/tests/data/img2.jpg M +16 -1 src/tests/imagetest.cpp M +2 -1 src/tests/imagetest.h https://invent.kde.org/office/tellico/commit/ae5202f8868c3816bdaef78526865c972f4f4b74 |