Bug 434525

Summary:	Rendering Plus Button (New Tab)
Product:	[Applications] yakuake	Reporter:	varlesh <varlesh>
Component:	general	Assignee:	Eike Hein <hein>
Status:	REPORTED ---
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	arrow-down Render PNG Render SVG

Description varlesh 2021-03-17 05:12:04 UTC

Created attachment 136765 [details]
arrow-down

After update to Yakuake 20.12.3 plus button have wrong rendering with SVG.
Also why need draw "arrow-down" icon on plus button? It's spoil all themes and Breeze too!!!
More info here: https://github.com/PapirusDevelopmentTeam/materia-kde/issues/108

Comment 1 varlesh 2021-03-17 05:14:14 UTC

Created attachment 136766 [details]
Render PNG

Comment 2 varlesh 2021-03-17 05:15:26 UTC

Created attachment 136767 [details]
Render SVG

Comment 3 varlesh 2021-03-17 05:17:14 UTC

Original SVG have very clean code:
https://github.com/PapirusDevelopmentTeam/materia-kde/blame/master/yakuake/skins/materia-dark/tabs/plus_over.svg

Comment 4 varlesh 2021-03-17 05:25:40 UTC

Please tell me why this needed and why this draw over plus button?
https://github.com/KDE/yakuake/blob/master/app/tabbar.cpp#L985

m_dropIndicator->setPixmap(QIcon::fromTheme(QStringLiteral("arrow-down")).pixmap(arrowSize, arrowSize, drawMode));

Comment 5 Nate Graham 2021-03-18 16:44:36 UTC

I imagine to communicate to the user that they can press-and-hold the button to access more options. If the icon isn't positioned properly, that's a bug.