Bug 434005

Summary: Remember the state of details sidebar when System Monitor is closed
Product: [Applications] plasma-systemmonitor Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: KSysGuard Developers <ksysguard-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ahiemstra, nate, plasma-bugs-null
Priority: NOR Keywords: usability
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/libksysguard/commit/cf77c8ceddfdd098be46ee63c9be4405659f8e45 Version Fixed/Implemented In:
Sentry Crash Report:

Description Patrick Silva 2021-03-05 12:33:20 UTC 
SUMMARY
if we close System Monitor with details sidebar enabled in 'Applications" view,
details sidebar needs to be enabled again when we re-open System Monitor > Applications view.


STEPS TO REPRODUCE
1. open System Monitor > Applications view
2. click on "Show details sidebar" button on top
3. close System Monitor
4. re-open System Monitor > Applications view

OBSERVED RESULT
details sidebar is disabled

EXPECTED RESULT
details sidebar should be enabled

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Bug Janitor Service 2021-03-08 17:24:53 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/136
Comment 2 Arjen Hiemstra 2021-03-09 16:24:03 UTC 
Git commit dc7a175d69fa8d05d58d94b0dc4298bc53165476 by Arjen Hiemstra.
Committed on 09/03/2021 at 11:40.
Pushed by ahiemstra into branch 'master'.

SensorFaceController: Save on destruction if the face requests it

This adds a property "ForceSaveOnDestroy" to the faceproperties file
that, if set, means SensorFaceController will save when destroyed, even
if "shouldSync" is set to false. This fixes issues where certain faces
would use face configuration for properties that change outside of an
"edit" mode.
Related: bug 433768, bug 433536

M  +2    -1    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/dc7a175d69fa8d05d58d94b0dc4298bc53165476
Comment 3 Arjen Hiemstra 2021-03-16 13:29:56 UTC 
Git commit cf77c8ceddfdd098be46ee63c9be4405659f8e45 by Arjen Hiemstra.
Committed on 16/03/2021 at 13:29.
Pushed by ahiemstra into branch 'Plasma/5.21'.

SensorFaceController: Save on destruction if the face requests it

This adds a property "ForceSaveOnDestroy" to the faceproperties file
that, if set, means SensorFaceController will save when destroyed, even
if "shouldSync" is set to false. This fixes issues where certain faces
would use face configuration for properties that change outside of an
"edit" mode.
Related: bug 433768, bug 433536


(cherry picked from commit dc7a175d69fa8d05d58d94b0dc4298bc53165476)

M  +2    -1    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/cf77c8ceddfdd098be46ee63c9be4405659f8e45