| Summary: |
Currency download from Yahoo uses "low" instead of "close" value |
| Product: |
[Applications] skrooge
|
Reporter: |
Christoph Vogtländer <kde> |
| Component: |
general | Assignee: |
Stephane MANKOWSKI <stephane> |
| Status: |
RESOLVED
FIXED
|
|
|
| Severity: |
normal
|
CC: |
stephane
|
| Priority: |
NOR
|
|
|
| Version First Reported In: |
unspecified | |
|
| Target Milestone: |
25.1.0 | |
|
| Platform: |
Other | |
|
| OS: |
Linux | |
|
|
Latest Commit:
|
https://invent.kde.org/office/skrooge/commit/4b1f206e597379e0d5e887ee05fd4370a643bdb1
|
Version Fixed/Implemented In:
|
|
|---|
|
Sentry Crash Report:
|
|
| |
|---|
| Attachments: |
quick and dirty workaround
|
Created attachment 136100 [details] quick and dirty workaround SUMMARY Version: 2.24.6 When downloading currency values using skrooge-yahoodl.py, Skrooge will use column "Low" instead of column "Close" (Skrooge does not seem to inspect the header but rather simply uses column "4" if I interpret the observed behavior correctly). STEPS TO REPRODUCE 1. download currency EURUSD=X with Yahoo 2. get raw data with "/usr/share/skrooge/skrooge-yahoodl.py EURUSD=X 2021-02-18 2021-02-18 1d" OBSERVED RESULT value for 17.02.2021 in Skrooge is 1,20 (1.202559) EXPECTED RESULT value for 17.02.2021 should be 1,21 (1.209248) SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 Kernel Version: 5.10.16-arch1-1 OS Type: 64-bit Graphics Platform: X11 Processors: 4 × Intel® Core™ i5-4460 CPU @ 3.20GHz Memory: 15.3 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 4600 ADDITIONAL INFORMATION When using stock values the effect is even more visible because stock values tend to vary a lot more over a day. As a quick and dirty workaround I modified skrooge-yahoodl.py and switch column 5 and 4. See attached patch (don't know if this would be an acceptable solution, it is rather ugly).