Bug 433037

Summary: Avatar does not preserve transparency in source image
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: twinshadows404
Component: generalAssignee: Marco Martin <notmart>
Status: CONFIRMED ---    
Severity: minor CC: mikel5764, nate, plasma-bugs
Priority: NOR    
Version: Master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: example

Description twinshadows404 2021-02-16 23:20:11 UTC
Created attachment 135747 [details]
example

It looks off when a white theme is used.
Comment 1 David Edmundson 2021-02-16 23:29:44 UTC
That's quite cropped. What is that a screenshot of?
Comment 2 twinshadows404 2021-02-17 00:46:50 UTC
The new plasma menu, the circle around the avatar is white while the menu is black.
Comment 3 Mikel Johnson 2021-02-17 16:05:38 UTC
not sure what you want here
Comment 4 twinshadows404 2021-02-17 16:18:33 UTC
Make it transparent like on the lock screen/ 
Keep the transparency from the icon
Comment 5 Mikel Johnson 2021-02-17 16:40:51 UTC
that's a framework thing then (Kirigami's Avatar)

also looks are most likely intentional but I digress
Comment 6 Marco Martin 2021-02-23 11:13:19 UTC
Yes, it's intentional.
API-wise is possible to have it, with

Avatar {
    background.color: "transparent"
}
Comment 7 Nate Graham 2021-02-23 15:17:07 UTC
Thanks. Moving back to Kickoff.
Comment 8 Nate Graham 2021-02-23 15:23:50 UTC
background.color: is not a valid public property. color: is a public property, but overriding that to be transparent impacts the appearance of the auto-generated image, which is not desired.

I cannot find a way to use the existing API to preserve transparency for non-auto-generated backgrounds. without impacting the auto-generated ones.

Moving back to Kirigami.
Comment 9 Mikel Johnson 2021-02-23 15:55:12 UTC
I think we'd wanna change the default to maintain consistency
Comment 10 Nate Graham 2021-02-23 16:51:23 UTC
Oops, forgot to move it. Thanks for doing so.