Bug 432693

Summary: Disabled "Search" action on Featured page
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol
Priority: HI Keywords: regression
Version First Reported In: 5.20.90   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/discover/commit/76b2f0604f40762d36dbcafb85bf1e80c6961cb5 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Disabled search action on featured page

Description Nate Graham 2021-02-09 16:11:37 UTC 
Created attachment 135534 [details]
Disabled search action on featured page

git bisect says it's was a regression from:

commit b0c52067283502d398fa0ffb974696322bf96af0 (HEAD, refs/bisect/good-b0c52067283502d398fa0ffb974696322bf96af0)
Author: Aleix Pol <aleixpol@kde.org>
Date:   Thu Feb 4 03:05:29 2021 +0100

    Show a "Search" main action on mobile on the Featured page
Comment 1 Bug Janitor Service 2021-02-10 01:16:14 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/76
Comment 2 Aleix Pol 2021-02-10 03:04:32 UTC 
Git commit 3fb0d529ca9544c312f426ca024dfcd053937611 by Aleix Pol.
Committed on 10/02/2021 at 01:11.
Pushed by apol into branch 'master'.

Don't show the search action on desktop mode

It's disabled anyway, it's just noise.

M  +1    -0    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/3fb0d529ca9544c312f426ca024dfcd053937611
Comment 3 Aleix Pol 2021-02-10 03:04:54 UTC 
Git commit 76b2f0604f40762d36dbcafb85bf1e80c6961cb5 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 10/02/2021 at 03:04.
Pushed by apol into branch 'Plasma/5.21'.

Don't show the search action on desktop mode

It's disabled anyway, it's just noise.


(cherry picked from commit 3fb0d529ca9544c312f426ca024dfcd053937611)

M  +1    -0    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/76b2f0604f40762d36dbcafb85bf1e80c6961cb5