| Summary: | Provisional tags are not displayed until another change is made | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | MarcP <iwannaberich> |
| Component: | Tags-Keywords | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | iwannaberich, metzpinguin |
| Priority: | NOR | ||
| Version: | 7.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Flatpak | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/commit/e50d6bffc51212fa56016a6a83b9bdcd62dd49ed | Version Fixed In: | 7.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
Normal behavior with first-level tags. No problem here.
Weird behavior when tag trees are involved |
||
|
Description
MarcP
2021-02-06 11:54:23 UTC
I cannot reproduce that and have never observed it. The tag appears immediately in the tags list. When a tag is created in the database, an event is sent to the Tag list models. The only explanation is that writing into the SQLite database takes a long time for you. Can this also be reproduced with the AppImage or only with the flatpack? Maik Ok, I have just tried with an appimage version of digikam (7.1 stable release), and the behavior is also there. But I realised something. This only occurs when the picture already has tags in form of a tree. So for instance. A pictures with just first-level tags, the new tags will appear immediately, no problem there. But as soon as hierarchical tags are involved, that weird behavior will appear. I have made two screen captures comparing the difference. One thing I forgot to mention was that I leave the "Tag already assigned" button on, since I have thousands of tags and otherwise it would be impossible to add keywords to pictures. Created attachment 135462 [details]
Normal behavior with first-level tags. No problem here.
Created attachment 135463 [details]
Weird behavior when tag trees are involved
Marc, you have a filtered tags view. If I fix the problem and update the filter after adding a tag, no new tag will be visible at all. The tags are not yet assigned to the image, the new tags should not appear at all, this is the intent of the filter, which should only display tags that are assigned to the image. Maik Yes, I know, but even considering that, there's something weird the way it works now (that also applies for Bug 431354, as it's likely the same thing). So, when you tag an image, the new tags you see in that panel have not yet written to the file, so even if the "Tags already assigned" filter is off, these tags should not appear. But they do. And only if they are not hierarchical. That's what I am reporting in this bug. Oh, and by the way, I realized that if you click and unclick the "tags already assigned" button, all tags appear at a given moment, so it's a workaround. Couldn't we force a "refresh" like that when each tag is added? In any case, I think the ideal behavior should be like this: You tag a picture, these keywords should already appear in the tag panel, but "pre-assigned" in a different color, as they won't be written until you hit apply. (that's already the case for reverse geotagging, where pre-assigned tags appear in green before being written). Then you hit "Apply", the new keywords are written to the file and appear in the default color just like any other tag. I don't know if you follow me, it can be a bit abstract at times... Git commit e50d6bffc51212fa56016a6a83b9bdcd62dd49ed by Maik Qualmann. Committed on 06/02/2021 at 18:21. Pushed by mqualmann into branch 'master'. show new assigned tags in the filtered tags view Related: bug 431354 FIXED-IN: 7.2.0 M +3 -1 NEWS M +8 -0 core/libs/models/albumfiltermodel.cpp M +5 -0 core/libs/models/albumfiltermodel.h M +1 -0 core/libs/properties/captions/itemdescedittab.cpp M +5 -0 core/libs/tags/widgets/tagcheckview.cpp https://invent.kde.org/graphics/digikam/commit/e50d6bffc51212fa56016a6a83b9bdcd62dd49ed I can always follow your explanations very well...((:-)) Maik Works perfectly. Thank you Maik, you are the best! |