Bug 431602

Summary: "Show current track" functionality has broken
Product: [Applications] Elisa Reporter: Nate Graham <nate>
Component: generalAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: normal CC: julien.dlq
Priority: VHI Keywords: regression
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/elisa/commit/afaf25d815763728ac842922dd422377f66079dc Version Fixed In: 20.12.2

Description Nate Graham 2021-01-14 17:19:00 UTC 
Clicking its button displays this in console output:

qrc:/qml/MediaPlayListView.qml:143: TypeError: Property 'positionViewAtIndex' of object PlayListBasicView_QMLTYPE_186(0x25f0880) is not a function


grep reveals that the function seems to have been removed or renamed:

nate@Liberator:~/kde/src/elisa$  (master) grep -ri positionViewAtIndex
src/qml/DraggableItem.qml:251:            _listView.positionViewAtIndex(model.index, ListView.Contain);
src/qml/MediaPlayListView.qml:143:                        playListView.currentItem.positionViewAtIndex(ElisaApplication.mediaPlayListProxyModel.currentTrackRow, ListView.Contain)
Comment 1 Nate Graham 2021-01-14 17:43:07 UTC 
Git bisect says I broke this in 3b80b0001239f8c6a35f95ff940e6ba596075310.

Will fix ASAP.
Comment 2 Bug Janitor Service 2021-01-14 17:54:54 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/211
Comment 3 Matthieu Gallien 2021-01-15 18:12:39 UTC 
Git commit afaf25d815763728ac842922dd422377f66079dc by Matthieu Gallien, on behalf of Nate Graham.
Committed on 15/01/2021 at 16:12.
Pushed by mgallien into branch 'release/20.12'.

Fix "show current track" button

I broke this in 3b80b0001239f8c6a35f95ff940e6ba596075310 by making
PlayListBasicView into a ScrollView, not a ListView. Therefore anything
that wants to target properties and functions of the list view item
needs to be adjusted to do so explicitly.
FIXED-IN: 20.12.2

M  +3    -3    src/qml/MediaPlayListView.qml
M  +1    -0    src/qml/PlayListBasicView.qml

https://invent.kde.org/multimedia/elisa/commit/afaf25d815763728ac842922dd422377f66079dc
Comment 4 Nate Graham 2021-01-26 05:41:24 UTC 
*** Bug 431822 has been marked as a duplicate of this bug. ***