| Summary: | Searching for "Switch user" finds an item called "New Session" | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | justin.zobel, kde, mikel5764, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.20.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=425970 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/c65938f36c715771bd8deebb22dde811a6e47bd7 | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
| Attachments: | Wrong item found | ||
|
Description
Nate Graham
2021-01-08 15:04:05 UTC
No screenshot attached. :) Created attachment 134827 [details]
Wrong item found
Derp
actually this is a general krunner problem bool switchUser = listAll || term.compare(i18n("switch user"), Qt::CaseInsensitive) == 0 || term.compare(i18n("new session"), Qt::CaseInsensitive) == 0;
if (switchUser && KAuthorized::authorizeAction(QStringLiteral("start_new_session")) && dm.isSwitchable() && dm.numReserve() >= 0) {
Plasma::QueryMatch match(this);
match.setType(Plasma::QueryMatch::ExactMatch);
match.setIconName(QStringLiteral("system-switch-user"));
match.setText(i18n("New Session"));
matches << match;
}
This seems intentional and has been the case since the initial import in 2014, @d_ed is there a rationale behind this? Like that switching users would in this case create a new session?
Seems like the intention was to match SDDM's prior behavior of creating new sessions by default instead of switching to a new one. However that default setting has since been changed, so these are now out of sync. And I think SDDM handles this itself right now, so the manual workaround is no longer needed. (That's as I understand it at least). A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1423 Git commit c65938f36c715771bd8deebb22dde811a6e47bd7 by Nate Graham, on behalf of Alexander Lohnau. Committed on 31/01/2022 at 18:01. Pushed by ngraham into branch 'master'. sessionrunner: Change text from "New Session" to "Switch User" This is how we call it since ~2016. Because of the string changes, it can not get cherry-picked to stable. M +1 -1 runners/sessions/sessionrunner.cpp https://invent.kde.org/plasma/plasma-workspace/commit/c65938f36c715771bd8deebb22dde811a6e47bd7 |