| Summary: | krita's existence loop kills the Finder | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Manga Tengu <mangatengu> |
| Component: | File formats | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | halla |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/3e1ef6893e6990011f93de76ae174e64e4aa5882 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Manga Tengu
2020-12-18 19:34:40 UTC
This sounds like it might have to do swith the updated macOS integration plugins. Since these commits are in krita/4.4.2, they are a regression and a release blocker. Amyspark, can you take a look? Ah, amyspark vacation -- I probably will revert the integration commits from krita/4.4.2 and test on my new mac. I asked yesterday for a crash log, which hasn't been uploaded here. Anyway, I think the problem is the Quick Look Thumbnailing generator - I'll MR its removal in a pinch. I asked you on the channel which part of the log you wanted. This is a corporate computer and sharing whole crash logs is not allowed. I still have the log and can still give you the parts you need. And as you guessed: Crashed Thread: 0 Dispatch queue: com.apple.quicklook.extensionmanager.accessextensions A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/626 Git commit 4165f6fbf84a32364fd0d155c39baca8fbf07412 by L. E. Segovia. Committed on 19/12/2020 at 12:47. Pushed by rempt into branch 'master'. Disable QuickLook Thumbnailing extension It is the only extension that applies to Catalina onwards, and the bug report says it takes down the Finder. As I don't have a crash report to fix, let's just disable it for now. It'll have to be revisited in the future, because QuickLook generators themselves are deprecated. M +2 -1 krita/integration/CMakeLists.txt M +3 -2 packaging/macos/osxdeploy.sh https://invent.kde.org/graphics/krita/commit/4165f6fbf84a32364fd0d155c39baca8fbf07412 If I'm not wrong this was not backported on the 4.3 branch which is the one I encountered the bug with. Git commit 3740597f3b0220232d7cf0f99cc6f6b56ed028f8 by L. E. Segovia. Committed on 19/12/2020 at 13:04. Pushed by lsegovia into branch 'krita/4.3'. Disable QuickLook Thumbnailing extension It is the only extension that applies to Catalina onwards, and the bug report says it takes down the Finder. As I don't have a crash report to fix, let's just disable it for now. It'll have to be revisited in the future, because QuickLook generators themselves are deprecated. (cherry picked from commit 4165f6fbf84a32364fd0d155c39baca8fbf07412) M +2 -1 krita/integration/CMakeLists.txt M +3 -2 packaging/macos/osxdeploy.sh https://invent.kde.org/graphics/krita/commit/3740597f3b0220232d7cf0f99cc6f6b56ed028f8 Git commit 3e1ef6893e6990011f93de76ae174e64e4aa5882 by L. E. Segovia. Committed on 19/12/2020 at 13:06. Pushed by lsegovia into branch 'krita/4.4.2'. Disable QuickLook Thumbnailing extension It is the only extension that applies to Catalina onwards, and the bug report says it takes down the Finder. As I don't have a crash report to fix, let's just disable it for now. It'll have to be revisited in the future, because QuickLook generators themselves are deprecated. (cherry picked from commit 4165f6fbf84a32364fd0d155c39baca8fbf07412) M +2 -1 krita/integration/CMakeLists.txt M +3 -2 packaging/macos/osxdeploy.sh https://invent.kde.org/graphics/krita/commit/3e1ef6893e6990011f93de76ae174e64e4aa5882 |