| Summary: | Fill layer with pattern and cloned layer display anomalous pattern | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | chrispbolduc |
| Component: | layer styles | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, halla, tamtamy.tymona |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | 4.4.2-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/aa86f66b0b0b9cd2d0a1fca0bda1ca6928462ccb | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | link to file that displays issue | ||
Thanks for the report! The link to the original post with more screenshots: https://krita-artists.org/t/first-beta-of-krita-4-4-2-help-in-testing-needed/15369/12?u=dkazakov Git commit 6adc6bfbb180bcb0b7bff172452ef9ba256a2e8e by Dmitry Kazakov. Committed on 15/12/2020 at 20:45. Pushed by dkazakov into branch 'krita/4.3'. Fix loading generator layers When loading generator layers we write directly into its internal filter, because KisFilterConfigutration does not have copying API. We used a hack for assigning this filter again, but it stopped working after generator layers got the ability to compare equality of the filter configurations. Related: bug 430246 M +1 -1 plugins/impex/libkra/kis_kra_load_visitor.cpp https://invent.kde.org/graphics/krita/commit/6adc6bfbb180bcb0b7bff172452ef9ba256a2e8e Git commit aa86f66b0b0b9cd2d0a1fca0bda1ca6928462ccb by Dmitry Kazakov. Committed on 15/12/2020 at 20:46. Pushed by dkazakov into branch 'krita/4.4.2'. Fix loading generator layers When loading generator layers we write directly into its internal filter, because KisFilterConfigutration does not have copying API. We used a hack for assigning this filter again, but it stopped working after generator layers got the ability to compare equality of the filter configurations. Related: bug 430246 M +1 -1 plugins/impex/libkra/kis_kra_load_visitor.cpp https://invent.kde.org/graphics/krita/commit/aa86f66b0b0b9cd2d0a1fca0bda1ca6928462ccb The bug is fixed in krita/4.3 and krita/4.4.2 branches. It should not be present in master branch, because that code has been refactored out during the resource rewrite. |
Created attachment 133987 [details] link to file that displays issue SUMMARY When I open file(made on 4.4.1) in the 4.4.2 beta, a fill layer with rough paper pattern and cloned layer, both display a grid pattern that was not part of the original file. STEPS TO REPRODUCE 1. open file 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION