| Summary: | plasma panel "+" and "-" size buttons are reversed for horizontal panel at top | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Alexandre Pereira <pereira.alex> |
| Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, bvnfuller, kde, nate, onyxnz1, parfenov.rajiv |
| Priority: | VHI | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/687935970717d9bb57b364ee95baae57d7f1b266 | Version Fixed In: | 5.20.5 |
| Sentry Crash Report: | |||
|
Description
Alexandre Pereira
2020-12-05 17:45:04 UTC
Caused by the fix I made for Bug 429063. Darn, this is in the stable branch, so it's a regression. :( David, I'm feeling stumped regarding how to fix this without either regressing the original fix for Bug 429063, or adding new API to the PlasmaCompoents3 SpinBox. Do you think you could help me come up with something? Was PC3's drag handler added purely for this panel use case? It seems weird for anything else, and it's adding functionality into the style. It was added specifically for this feature, but the intent was do implement it in the component itself because the drag-to-change-the-value behavior was deemed generally desirable. We'd like to put this in the Breeze desktop spinbox too. *** Bug 430531 has been marked as a duplicate of this bug. *** > We'd like to put this in the Breeze desktop spinbox too.
Styles are for styling. New features are best served with a decorator pattern or subclasses. We don't have this situation then.
In terms of moving forward and options within the current code.
Option 1:
Go with your original patch in frameworks. This must remain an exception and not a rule.
Guard usage on the client side with
`
Component.onCompleted: if (self.hasOwnProperty("reverseDragAndScrollDirections")) {
self.reverseDragAndScrollDirections = true;
}
`
so it's backportable and won't break when we move to generic styles.
and drop the stepSize change
Option 2:
Same but in reverse. Have the style query `control.hasOwnProperty("reverseDragAndScrollDirections") && control.reverseDragAndScrollDirections`
Then declare that as a new property in the panel's spinbox.
It'd be closer to how Breeze does additional things from widget controls
Option3:
Spinbox.down.indicator is public API, we can re-implement the relevant FrameSVG code, but swap the +/-
and keep the current negative stepsize
Option4:
override contentItem inside the panel
and keep the current negative stepsize
Git commit 3a0ce695fd09b1b1094c8fbdd991d9e32ae399e2 by Nate Graham, on behalf of Srevin Saju. Committed on 26/12/2020 at 15:25. Pushed by ngraham into branch 'master'. revert: bf7d64b3 . Fixes panel height adjusting fails when the panel is on top / left M +1 -4 desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml https://invent.kde.org/plasma/plasma-desktop/commit/3a0ce695fd09b1b1094c8fbdd991d9e32ae399e2 Git commit 687935970717d9bb57b364ee95baae57d7f1b266 by Nate Graham, on behalf of Srevin Saju. Committed on 26/12/2020 at 15:26. Pushed by ngraham into branch 'Plasma/5.20'. revert: bf7d64b3 . Fixes panel height adjusting fails when the panel is on top / left (cherry picked from commit 3a0ce695fd09b1b1094c8fbdd991d9e32ae399e2) M +1 -4 desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml https://invent.kde.org/plasma/plasma-desktop/commit/687935970717d9bb57b364ee95baae57d7f1b266 *** Bug 430871 has been marked as a duplicate of this bug. *** *** Bug 430955 has been marked as a duplicate of this bug. *** |