| Summary: | Buttons/ToolButtons in ActionToolBars don't respect Theme.colorSet and Theme.inherit | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Noah Davis <noahadvs> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | REOPENED --- | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=429399 | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/fe101efd201255a61e47f387b2aa6d59da829f7c | Version Fixed In: | |
| Attachments: |
Correct appearance for qqc2-breeze-style
Incorrect appearance for qqc2-breeze-style Material: Correct (top) and incorrect (bottom) Default: Incorrect (top) and correct (bottom) Colors only correct on first press with qqc2-breeze-style |
||
|
Description
Noah Davis
2020-12-03 14:40:55 UTC
Created attachment 133834 [details]
Correct appearance for qqc2-breeze-style
Created attachment 133835 [details]
Incorrect appearance for qqc2-breeze-style
Created attachment 133836 [details]
Material: Correct (top) and incorrect (bottom)
The incorrect style looks better and closer to modern Android, but it's still incorrect.
Created attachment 133837 [details]
Default: Incorrect (top) and correct (bottom)
Whoops, I named the Material screenshot incorrectly. Top is incorrect and bottom is correct. Also, you can't actually see the problem in the Fusion style since it hardcodes more of its button appearance and uses window color for toolbars (except for the gradient, but Kirigami doesn't use QQC2 ToolBars), so disregard what I said about Fusion. Theme.inherit being true seems like a bug. If you force the color set to something non-default, you're suppose to turn off inheritance, not force it to on. The results will be nonsensical, as you're reporting. I wonder if this is what's causing Bug 429399. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/184 Git commit fe101efd201255a61e47f387b2aa6d59da829f7c by Marco Martin. Committed on 09/12/2020 at 15:07. Pushed by mart into branch 'master'. Color icons, not buttons when an icon color is set, it tried to color the button and the icon causing often ureadable results. now color just the icon but not the button, giving a less magic behavior. it won't be possible to color non monochrome icons, but that's kinda expected and should be an acceptable compromise Related: bug 429399 M +2 -2 src/controls/ActionToolBar.qml M +0 -6 src/controls/private/PrivateActionToolButton.qml https://invent.kde.org/frameworks/kirigami/commit/fe101efd201255a61e47f387b2aa6d59da829f7c Unfortunately, that commit didn't completely fix the issue. With qqc2-breeze-style, the buttons have the correct pressed color on the first press, but not on any press after that. Created attachment 134061 [details]
Colors only correct on first press with qqc2-breeze-style
|