Bug 429905

Summary:	Proxy clips used in rendering again
Product:	[Applications] kdenlive	Reporter:	Martin Pecka <peci1>
Component:	Rendering & Export	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	major	CC:	peci1
Priority:	NOR
Version First Reported In:	20.08.2
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Project files related to STR

Description Martin Pecka 2020-12-01 18:56:20 UTC

Created attachment 133781 [details]
Project files related to STR

I know this has already happened, and it seems it is here again (previous related bugs are https://bugs.kde.org/show_bug.cgi?id=354601, https://bugs.kde.org/show_bug.cgi?id=371064, https://bugs.kde.org/show_bug.cgi?id=387092 - all marked as either solved, or confirmed, but stale).

The described behavior was observed in 20.08.2, 20.08.3 and today's daily build on Windows 10.

STR:

0) kdenlive global config - proxy clips are disabled
1) create a new project (1080p 30fps) (the project should have proxy clips disabled in its settings)
2) import a 1080p clip
3) add the clip to timeline (renders ok)
4) save the project and restart kdenlive
5) after restart, enable Proxy clips for the project, and their automatic generating for videos larger than 1000px. (renders ok)
6) save the project and restart kdenlive
7) after restart, render the project again. (renders using proxy)

I attach a series of project files that was generated by saving the project during these STR.

The bug first manifested in a large project with many different videos of many formats and codecs, that's why I don't include the particular video that was used. It should be triggered by any FullHD video.

I certainly do NOT check the option to render using proxy clips in the render dialog :)

Comment 1 Martin Pecka 2020-12-01 18:59:17 UTC

I also got this error between steps 3 and 4:

Your project file was upgraded to the latest Kdenlive document version, but it was not possible to create the backup copy D:/Download/test3/test4_after_restart_backup0.kdenlive.

I do not see this error normally, it was just triggered by the frequent usage of "Save project as". And it shouldn't influnce the usage of proxies, because step 5 still renders fine.

Comment 2 Jean-Baptiste Mardelle 2020-12-02 15:59:42 UTC

Git commit bd8b6cdf60904542bd71bcfd19ab5664b10640f9 by Jean-Baptiste Mardelle.
Committed on 02/12/2020 at 15:59.
Pushed by mardelle into branch 'release/20.12'.

Fix possibly incorrect rendering on Windows (proxy used when they shouldn't)

M  +1    -1    src/dialogs/renderwidget.cpp
M  +1    -1    src/doc/kdenlivedoc.cpp

https://invent.kde.org/multimedia/kdenlive/commit/bd8b6cdf60904542bd71bcfd19ab5664b10640f9

Comment 3 Martin Pecka 2020-12-02 22:05:58 UTC

Thanks for the patch. Should I test it with tomorrow's daily build, or is more work needed?

Comment 4 Jean-Baptiste Mardelle 2020-12-03 02:10:04 UTC

yes please test with the daily build and let me know. Thanks a lot

Comment 5 Martin Pecka 2020-12-03 21:55:57 UTC

Now I get a freeze as soon as I press Render button in step 3.

Comment 6 Martin Pecka 2020-12-04 09:48:04 UTC

Thanks! Today's nightly works and the bug doesn't manifest there anymore.