| Summary: | Re-enable “show password” button on login screen | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Manuel Strehl <org.kde> |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | 61kylyqt, a.samirh78, anditosan1000, bharadwaj.raju777, bhush94, davestechshop, dmatteo002, filipfila.kde, kde, nate, pavel23dob, plasma-bugs |
| Priority: | NOR | Keywords: | usability |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D9040 | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=494534 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Manuel Strehl
2020-11-25 06:37:07 UTC
I have the same child-related use case and your complaint makes sense to me. We can re-consider. I understand the use case. I think it is sensible. I feel there "should" be a setting that enables this in the lock screen. However, I also believe, this button could be a potential security risk. Because of that, I would suggest having a setting for the lock screen that a user can enable/disable to have the reveal button back. The setting should contain a warning letting the user know the potential risk and allow the user to continue. >We can re-consider.
The amount of other bugs the other thing received was quite substantial. I don't want to blindly re-add it. What Andres said might be doable.
In either case, we need the icon problem solved before it goes back; that was the biggest problem with it.
I support re-adding it. It's essential for us. We had no problems with it. But removing it has caused me lots of support headaches. I vote for putting it back as-is and then work on addressing the issues without removing essential functionality. Thank you. *** Bug 442869 has been marked as a duplicate of this bug. *** There are some comments in bug https://bugs.kde.org/show_bug.cgi?id=442869 that might be useful for this bug report: https://bugs.kde.org/show_bug.cgi?id=442869#c3 https://bugs.kde.org/show_bug.cgi?id=442869#c4 I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue? >I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue?
One issue was SDDM didn't load the icon and we want them in sync.
(In reply to David Edmundson from comment #8) > >I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue? > > One issue was SDDM didn't load the icon and we want them in sync. I'm actually not seeing the reveal password icon on the *lock* screen when using the (light) Breeze theme, but the button shows up on the login screen for me. Breeze global theme: https://i.ibb.co/xXPZt1c/Breeze-Login-Screen.jpg Breeze Dark global theme: https://i.ibb.co/Ct5SNxJ/Third-Party-Login-Screen.jpg It only fails when the combination of a dark Plasma theme + icon theme with missing icons are synced to the login screen, which is bug 494534 and isn't specific to the reveal password icon. Example: https://i.ibb.co/bK4SPLw/Breeze-Dark-Login-Screen.jpg And the same when restoring SDDM to default theme settings: https://i.ibb.co/qB3Qx93/SDDM-Factory-Settings.jpg The components have been reworked since the button was disabled so maybe that helped. It used to be a PlasmaComponents2.TextField, now it's a PlasmaExtras.PasswordField. Yeah, looks like there's just Bug 494534 now which is a general pre-existing issue, not an issue specific to that button. |
