Summary: | Lock the recursive button when not applicable to make it less confusing | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Raghavendra kamath <raghu> |
Component: | Tools/Transform | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tomtomtomreportingin |
Priority: | NOR | ||
Version: | 4.4.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/93faf98fb81b8a674bf5200469b35a88149a0470 | Version Fixed In: |
Description
Raghavendra kamath
2020-11-22 13:53:52 UTC
I can confirm this. Seems it happens as far as 4.1, and I haven't checked versions previous to that. After clarification from Dmitry, it seems this isn't a problem of broken functionality but rather unclear documentation. As noted in the IRC, the option is automatically used on non-paintable layers like group layers, so changing the setting only changes when working with paint layers with masks, for example. As suggested in the IRC, the button should be locked where it isn't applicable. I changed the title of this bug after Dmitry's suggestion in the chatroom. The button should be disabled or locked when it is not applicable. It only works on paint layers with masks. As per tomtom's suggestion we should change the text of the tooltip to more clearly explain the feature. Git commit 93faf98fb81b8a674bf5200469b35a88149a0470 by Dmitry Kazakov, on behalf of Srirupa Datta. Committed on 31/05/2021 at 12:54. Pushed by dkazakov into branch 'master'. Remove work recursively button All layers and groups work recursively now. To achieve unrecursive behaviour, lock the layer/mask. GUI: FIXED IN: 5.0.0 M +9 -15 plugins/tools/tool_transform2/kis_tool_transform.cc M +1 -2 plugins/tools/tool_transform2/kis_tool_transform.h M +2 -11 plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp M +1 -2 plugins/tools/tool_transform2/kis_tool_transform_config_widget.h M +4 -4 plugins/tools/tool_transform2/kis_transform_utils.cpp M +1 -1 plugins/tools/tool_transform2/kis_transform_utils.h M +1 -4 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +0 -1 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.h M +2 -3 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp M +0 -2 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h M +18 -31 plugins/tools/tool_transform2/wdg_tool_transform.ui https://invent.kde.org/graphics/krita/commit/93faf98fb81b8a674bf5200469b35a88149a0470 |