Bug 429356

Hi,

When you build Skrooge, you can choose if you want to build it with WebEngineWidgets or WebKitWidgets.

For that, you have to use -DSKG_WEBENGINE=OFF|ON in your CMake commande.

Is it acceptable or do you want to be able to build Skrooge without web engine included ? Of course, this will remove some important features ("Monthly reports", ...)

QtWebKit seems to be even less maintained.

I understand that building with neither may lose functionality.
(Although maybe you can still generate reports and XDG-open them?)

Git commit 436fe5bff964c9a05a4bba52872a72bdd8c96400 by Stephane MANKOWSKI.
Committed on 06/12/2020 at 20:07.
Pushed by smankowski into branch 'master'.

Please make qtwebengine dependency optional

M  +5    -0    CHANGELOG
M  +12   -5    CMakeLists.txt
M  +3    -3    README
M  +5    -4    appimage.yml
M  +-    --    images/splash.png
M  +5032 -4359 images/splash.svg.in
M  +4    -0    plugins/generic/skg_file/tests/CMakeLists.txt
M  +4    -0    plugins/generic/skg_monthly/CMakeLists.txt
M  +18   -11   plugins/generic/skg_monthly/skgmonthlyplugin.cpp
M  +10   -2    plugins/generic/skg_monthly/skgmonthlyplugin.h
M  +12   -4    plugins/generic/skg_monthly/skgmonthlypluginwidget.cpp
M  +4    -0    plugins/generic/skg_print/CMakeLists.txt
M  +16   -4    plugins/generic/skg_print/skgprintplugin.cpp
M  +11   -4    plugins/generic/skg_print/skgprintplugin.h
M  +4    -0    plugins/skrooge/skrooge_bank/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_report/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_report/tests/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_unit/CMakeLists.txt
M  +2    -2    scripts/skrooge-release.py
M  +7    -2    skgbankgui/CMakeLists.txt
M  +7    -2    skgbankguidesigner/CMakeLists.txt
M  +7    -2    skgbasegui/CMakeLists.txt
M  +2    -1    skgbasegui/skgtablewithgraph.cpp
M  +13   -4    skgbasegui/skgtabpage.cpp
M  +0    -3    skgbasegui/skgtabpage.h
M  +44   -12   skgbasegui/skgwebview.cpp
M  +141  -116  skgbasegui/skgwebview.h
M  +7    -2    skgbaseguidesigner/CMakeLists.txt
M  +4    -0    skrooge/CMakeLists.txt
M  +1    -1    snapcraft.yaml
M  +4    -0    tests/skgbaseguitest/CMakeLists.txt

https://invent.kde.org/office/skrooge/commit/436fe5bff964c9a05a4bba52872a72bdd8c96400

Is there a technical reason why deprecated old Qt5WebKit is preferred by default over Qt5WebEngine?

Qt5WebKit is the first implementation.
Qt5WebEngine is an alternative but doesn't work as well the first one (print issue).

That's why Qt5WebKit is still the default.