| Summary: | Track ordering in Album view is messed up | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fake.name |
| Priority: | VHI | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/c99481d94fd5d67a85227cf4c74f49f254d2771b | Version Fixed In: | 22.08 |
| Sentry Crash Report: | |||
| Attachments: | Tracks out of order | ||
Git bisect says this was caused by 645550dfafbfb14da250baa5f92c91a833cf33d9. Sorry for not noticing until now. I do not reproduce the bug in itself but I am getting lots of warnings in the console. qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined Do you also see them ? That should be fixed now, but the originally-reported problem remains. *** Bug 449885 has been marked as a duplicate of this bug. *** Git commit c99481d94fd5d67a85227cf4c74f49f254d2771b by Nate Graham. Committed on 05/04/2022 at 02:07. Pushed by ngraham into branch 'master'. Collapse ListBrowserView into DataListView Just like the prior commit, this does the same thing to ListBrowserView to reduce code duplication and simplify the control flow, which will make it harder for subtle bugs to creep in, such as 429036 which seems to be fixed with this refactor. FIXED-IN: 22.08 M +0 -1 src/CMakeLists.txt M +181 -53 src/qml/DataListView.qml D +0 -187 src/qml/ListBrowserView.qml M +0 -1 src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/c99481d94fd5d67a85227cf4c74f49f254d2771b |
Created attachment 133277 [details] Tracks out of order Seems like a recent regression. Tracks are listed out of order in the Album view (not Artist view > Album, just Album view). Will bisect shortly.