Summary: | kdeinit5 crashes when Dolphin filters audio files | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kinit | Reporter: | Patrick Silva <bugseforuns> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | elxreno, kde, kdelibs-bugs, liubomirwm, nate, postix, stefan.bruens |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
URL: | https://github.com/taglib/taglib/issues/974 | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=430862 https://bugs.kde.org/show_bug.cgi?id=469458 |
||
Latest Commit: | https://invent.kde.org/network/kio-extras/-/commit/39174377a5cd233c2043912867a8047c41bdd1fc | Version Fixed In: | 23.08 |
Attachments: | file that causes crash |
Description
Patrick Silva
2020-10-08 13:48:16 UTC
It's crashing in TagLib on one of your MP4 files: [KCrash Handler] #6 0x00007f1e1d4d8314 in TagLib::MP4::Tag::itemMap() const () from /lib/x86_64-linux-gnu/libtag.so.1 #7 0x00007f1e1d79d7ad in parseMP4Tag<TagLib::MP4::File> (img=..., file=...) at ./thumbnail/audiocreator.cpp:175 #8 AudioCreator::create (this=<optimized out>, path=..., img=...) at ./thumbnail/audiocreator.cpp:175 Please report this to the TagLib developers at https://github.com/taglib/taglib/issues It would be super helpful if you could figure out which MP4 file is causing the crash and attach it to the bug report you file over there. Ok, I have found the culprit file. Unfortunately taglib seems an abandonware, no release in almost 4 years. :( Thanks Nate. @(In reply to Patrick Silva from comment #2) > Ok, I have found the culprit file. > Unfortunately taglib seems an abandonware, no release in almost 4 years. :( > Thanks Nate. Please attach the file directly to the bugreport. Having to download a problematic file from a random third party server is super annoying. Created attachment 132949 [details]
file that causes crash
Works on openSUSE Tumbleweed. We use a git snapshot for exactly this reason: 1.11.2~git20190725.79bc9ccf humm, this crash was also reproducible on my Arch Linux. I have just replaced taglib package from Arch repos with taglib-git from AUR and now the crash is fixed. *** Bug 407393 has been marked as a duplicate of this bug. *** *** Bug 439034 has been marked as a duplicate of this bug. *** @Patrick Silva: Since you can reproduce, please try https://invent.kde.org/network/kio-extras/-/merge_requests/240 Currently I can't reproduce. Operating System: Arch Linux KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.106.0 Qt Version: 5.15.9 Graphics Platform: Wayland (In reply to Kai Uwe Broulik from comment #9) > @Patrick Silva: Since you can reproduce, please try > https://invent.kde.org/network/kio-extras/-/merge_requests/240 I could try your patch and check if this fixed #469458 for me, if you explain shortly how I can _run a Plasma session with a custom kio-extra build_ (compiled with kdesrc-build). :) Anyway, I built the current plasma5 branch of plasma-workspace, plasma-desktop, dolphin and kio-extra and could no longer reproduce #469458, even without Kai's patch. Git commit 39174377a5cd233c2043912867a8047c41bdd1fc by Kai Uwe Broulik. Committed on 25/05/2023 at 19:13. Pushed by broulik into branch 'master'. audiocreator: Check tag against null In earlier versions of taglib it wasn't guaranteed that a "tag" existed when the respective "has" method returned true. This can lead to null pointer access. M +3 -3 thumbnail/audiocreator.cpp https://invent.kde.org/network/kio-extras/-/commit/39174377a5cd233c2043912867a8047c41bdd1fc |