Summary: | Systray icons limited to 2 rows on very thick panels | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | agentxlax <agentxlax0> |
Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | materka, nate |
Priority: | VHI | Keywords: | regression |
Version: | 5.19.90 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/a54d1901bdb4ee1fe2aeb22786893997173d31f1 | Version Fixed In: | 5.20 |
Description
agentxlax
2020-10-02 14:37:04 UTC
Nate, as I can see from commit log, this is intended, right? Currently yes. Easily changeable though. I can look into it, since I can see that this is indeed a minor regression for people with really really thick panels. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/317 Please test the above if possible :) WOW looks like you guys are right on top of this. I'm assuming the link in the above post is for internal testing for right now? Nate created a fix in 8 minutes, which is impressively super fast! @agentxlax you can test this fix without compiling Plasma from sources, just modify: /usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml and change line: > readonly property int rowsOrColumns: autoSize || cellThickness <= smallIconSize * 2 ? 1 : 2 to > readonly property int rowsOrColumns: autoSize ? 1 : Math.max(1, Math.floor(cellThickness / smallIconSize)) Git commit 649b50cdfe5e177f03e4cc075a8e50507eb47636 by Nate Graham. Committed on 02/10/2020 at 20:45. Pushed by ngraham into branch 'master'. [applets/systemtray] Fix size of grid on really thick panels Now the grid can have more than 2 rows/columns on really thick panels, just like in Plasma 5.19 and earlier. FIXED-IN: 5.20 M +1 -1 applets/systemtray/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/649b50cdfe5e177f03e4cc075a8e50507eb47636 Git commit a54d1901bdb4ee1fe2aeb22786893997173d31f1 by Nate Graham. Committed on 02/10/2020 at 20:46. Pushed by ngraham into branch 'Plasma/5.20'. [applets/systemtray] Fix size of grid on really thick panels Now the grid can have more than 2 rows/columns on really thick panels, just like in Plasma 5.19 and earlier. FIXED-IN: 5.20 (cherry picked from commit 649b50cdfe5e177f03e4cc075a8e50507eb47636) M +1 -1 applets/systemtray/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/a54d1901bdb4ee1fe2aeb22786893997173d31f1 Too late, someone else reviewed it and I merged. :) Thanks looks perfect, greatly appreciated. blob:blob://https://imgur.com/713d92aa-63b1-4835-9a03-a75868eb30c3 |