| Summary: | Dolphin not opening | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Dr.Dev <sadramicro20> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | crash | CC: | alimz98, elvis.angelaccio, holger.werb, jodr666, joecitizen555, juliandeveloper0, kde, kfm-devel, klwilcoxon, martin.sandsmark, nate |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 20.08.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=416522 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Valgrind log
New crash information added by DrKonqi New crash information added by DrKonqi |
||
|
Description
Dr.Dev
2020-09-23 11:01:56 UTC
[KCrash Handler] #4 0x00007f834f02f38d in DolphinViewContainer::url (this=0x0) at ./src/dolphinviewcontainer.cpp:273 #5 0x00007f834f0269c5 in DolphinMainWindow::preferredSearchTool (this=this@entry=0x560b35bb7c70) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:794 #6 0x00007f834f026ce5 in DolphinMainWindow::updateOpenPreferredSearchToolAction (this=0x560b35bb7c70) at ./src/dolphinmainwindow.cpp:994 That's odd. KBookmarkManager::saveAs() shows a critical messagebox at #25, which runs a nested event loop. The object tree is probably modified because of user actions that are handled there. *** Bug 427418 has been marked as a duplicate of this bug. *** [KCrash Handler] #4 0x00007f834f02f38d in DolphinViewContainer::url (this=0x0) at ./src/dolphinviewcontainer.cpp:273 #5 0x00007f834f0269c5 in DolphinMainWindow::preferredSearchTool (this=this@entry=0x560b35bb7c70) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:794 #6 0x00007f834f026ce5 in DolphinMainWindow::updateOpenPreferredSearchToolAction (this=0x560b35bb7c70) at ./src/dolphinmainwindow.cpp:994 Created attachment 133797 [details]
Valgrind log
I am not entirely sure if am hitting this one, please check the attachment.
In my case if i run dolphin throw valgrind it will crash immediately.
Running it normally it will open but as soon as i right click over any white space or over folder/file in the dolphin window it will crash with no logs or dumps indicating what happen.
Introduced by this, I think: commit 9f268f5f76a4a4f0c91abcc213e159c8bde4869c Author: Kai Uwe Broulik <kde@privat.broulik.de> Date: Tue May 5 12:05:18 2020 +0200 Don't use local URL for KMoreTool This method is called a billion times and spawns a blocking(!) StatJob. KFind can search local URLs, too, so I don't see why this is necessary. Either way, I'd rather have a non-KDE search tool broken than the app. Ideally, I'd like this entire thing redone to use an async StatJob, if any. Fwiw the KMoreTools in the free space bar doesn't use a local URL either. BUG: 420911 FIXED-IN: 20.04.1 Differential Revision: https://phabricator.kde.org/D29442 diff --git src/dolphinmainwindow.cpp src/dolphinmainwindow.cpp index f88bc3f44..7ad136fe7 100644 --- src/dolphinmainwindow.cpp +++ src/dolphinmainwindow.cpp @@ -956,7 +956,7 @@ QPointer<QAction> DolphinMainWindow::preferredSearchTool() { m_searchTools.clear(); KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames( - &m_searchTools, { "files-find" }, QUrl::fromLocalFile(activeContainerLocalPath()) + &m_searchTools, { "files-find" }, m_activeViewContainer->url() ); QList<QAction*> actions = m_searchTools.actions(); if (actions.isEmpty()) { MRs welcome :) Don't really know how to fix it easily apart from reverting the implementation commits, I don't think it is easily fixable without re-implementing the commits introducing this. FWIW, what I mean (and I might be wrong): the common thing with a lot of the recently introduced crashes is that people are removing the ::exec()-s, without fixing the original reasons they weren't asynchronous. So the easiest fix is to revert back to the old synchronous behavior, and then cleaning up the "architecture" (in this case I think there is an assumption on ordering wrt. creation of widgets and actions that is broken). Created attachment 134114 [details]
New crash information added by DrKonqi
dolphin (20.12.0) using Qt 5.15.2
- What I was doing when the application crashed:
The first time was after opening qBittorrent. After that, Dolphin won't start.
-- Backtrace (Reduced):
#4 0x00007fd89965c63b in KUrlNavigator::locationUrl(int) const () from /lib/x86_64-linux-gnu/libKF5KIOFileWidgets.so.5
#5 0x00007fd899a42af8 in DolphinViewContainer::setSearchModeEnabled (this=this@entry=0x559a56253110, enabled=true) at /usr/include/c++/9/bits/atomic_base.h:413
#6 0x00007fd899a44399 in DolphinViewContainer::DolphinViewContainer (this=0x559a56253110, url=..., parent=<optimized out>) at ./src/dolphinviewcontainer.cpp:188
#7 0x00007fd899a4ac45 in DolphinTabPage::createViewContainer (this=this@entry=0x559a56262240, url=...) at ./src/dolphintabpage.cpp:432
#8 0x00007fd899a4af4f in DolphinTabPage::DolphinTabPage (this=0x559a56262240, primaryUrl=..., secondaryUrl=..., parent=<optimized out>) at ./src/dolphintabpage.cpp:34
Created attachment 134168 [details]
New crash information added by DrKonqi
dolphin (20.12.0) using Qt 5.15.2
Last night I updated 6 apps using the discover app:
libpipewire-0.3-0:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), pipewire:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), distro-release-notifier:amd64 (0.0+p20.04+git20201129.0022-0, 0.0+p20.04+git20201216.0022-0), libspa-0.2-modules:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), libpipewire-0.3-modules:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), pipewire-bin:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10)
And today I wanted to open the Dolphin app, which gave me an error every time
-- Backtrace (Reduced):
#4 0x00007f3eb58cd63b in KUrlNavigator::locationUrl(int) const () from /lib/x86_64-linux-gnu/libKF5KIOFileWidgets.so.5
#5 0x00007f3eb5cb3af8 in DolphinViewContainer::setSearchModeEnabled (this=this@entry=0x55bfcaea8a70, enabled=true) at /usr/include/c++/9/bits/atomic_base.h:413
#6 0x00007f3eb5cb5399 in DolphinViewContainer::DolphinViewContainer (this=0x55bfcaea8a70, url=..., parent=<optimized out>) at ./src/dolphinviewcontainer.cpp:188
#7 0x00007f3eb5cbbc45 in DolphinTabPage::createViewContainer (this=this@entry=0x55bfcaf55d70, url=...) at ./src/dolphintabpage.cpp:432
#8 0x00007f3eb5cbbf4f in DolphinTabPage::DolphinTabPage (this=0x55bfcaf55d70, primaryUrl=..., secondaryUrl=..., parent=<optimized out>) at ./src/dolphintabpage.cpp:34
this issue is pretty bad, dolphin is basically impossible to use without manually finding the config file and deleting it. can anyone experiencing this try reverting 9f268f5f76a4a4f0c91abcc213e159c8bde4869c and see if that helps? never mind, I think it is fixed by this: https://invent.kde.org/system/dolphin/-/commit/c95d7fae79a309ed7f2df393fa20257cb20d54a8 so test with current git master and see if it is fixed, I guess I took a screenshot and when I wanted to determine the path of the save, I tried it with dolphin and now it has been fixed! *** Bug 430831 has been marked as a duplicate of this bug. *** *** Bug 430758 has been marked as a duplicate of this bug. *** Closing as duplicate, if someone can still reproduce it even with the fix applied, please reopen it. *** This bug has been marked as a duplicate of bug 429628 *** |