| Summary: | [Wayland] (Optionally) disable new layout OSD | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Alexander Potashev <aspotashev> |
| Component: | input | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, butirsky, katyaberezyaka, szlogan11 |
| Priority: | NOR | Flags: | butirsky:
Wayland+
butirsky: Decision-Required+ |
| Version: | 5.18.5 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=418699 https://bugs.kde.org/show_bug.cgi?id=376460 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/86381afb241ac0d3d70947819e8971a14300518a | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | 390079, 418699 | ||
| Bug Blocks: | |||
|
Description
Alexander Potashev
2020-09-12 17:17:50 UTC
might be a duplicate of bug #418699 https://bugs.kde.org/show_bug.cgi?id=376460 https://invent.kde.org/plasma/kwin/-/merge_requests/217#note_104982 Osd about volume change is useful, osd about changed playback device is useful, seeing osd about layout switching (which i do A LOT) is very distracting, annoying and useless as i use keyboard layout applet in tray. Please, add option to disable only this OSD notification. There is two cases when OSD is shown: - user actually changed layout (by a shortcut or so) - start typing in window with new layout (when not on Global layout Policy) What kind of OSD it's proposed to suppress here? (In reply to Andrey from comment #3) > There is two cases when OSD is shown: > - user actually changed layout (by a shortcut or so) > - start typing in window with new layout (when not on Global layout Policy) > > What kind of OSD it's proposed to suppress here? I, for example, don't want to see any of this two. (In reply to ruruoli from comment #4) > I, for example, don't want to see any of this two. +1 (In reply to ruruoli from comment #2) > seeing osd about layout switching (which i do A LOT) is very > distracting, annoying and useless as i use keyboard layout applet in tray. > Please, add option to disable only this OSD notification. What applet are you using? AFAIK it's not ready yet for Wayland. (In reply to Andrey from comment #6) > (In reply to ruruoli from comment #2) > > seeing osd about layout switching (which i do A LOT) is very > > distracting, annoying and useless as i use keyboard layout applet in tray. > > Please, add option to disable only this OSD notification. > > What applet are you using? AFAIK it's not ready yet for Wayland. I use standard applet on x11. On X11 you shouldn't have such problem because it has no layout OSD when switching shortcut configured as "Primary"(IIRC) in Settings. (In reply to Andrey from comment #8) > On X11 you shouldn't have such problem because it has no layout OSD when > switching shortcut configured as "Primary"(IIRC) in Settings. I want to switch to Wayland, and this keyboard layout OSD is the only thing that keeps me from doing this. (In reply to Andrey from comment #6) > (In reply to ruruoli from comment #2) > > seeing osd about layout switching (which i do A LOT) is very > > distracting, annoying and useless as i use keyboard layout applet in tray. > > Please, add option to disable only this OSD notification. > > What applet are you using? AFAIK it's not ready yet for Wayland. https://invent.kde.org/plasma/kwin/commit/cba895e7239e5919aa15adfb4e71ad72fb6c0806 (In reply to ruruoli from comment #10) > (In reply to Andrey from comment #6) > > What applet are you using? AFAIK it's not ready yet for Wayland. > > https://invent.kde.org/plasma/kwin/commit/ > cba895e7239e5919aa15adfb4e71ad72fb6c0806 It's not the applet corresponding to X11's one :) The fix just make it show layout correctly when you hover that "applet", but it doesn't show the layout permanently as X11 does. The new applet is in developing now, but until it ready we really don't have other way to know current layout than OSD.. That OSD can be disabled unchecking "Display visual feedback for status changes" in System Settings > Workspace Behavior > General Behavior. (In reply to Patrick Silva from comment #12) > That OSD can be disabled unchecking "Display visual feedback for status > changes" in System Settings > Workspace Behavior > General Behavior. I want to disable only layout change OSD, not all, OSD related to volume change or changed audio output is useful. Layout indicator was fixed, any progress on disabling/removing these annoying osd? It will be disabled permanently on Alt+Tab switching, if the windows have different keyboard layout. I hoped it will solve major part of the problem, if you don't think so - please reply, preferably with argumentation. We will have to think how to do that then, currently I have no ready solution. Maybe it should be regulated on theme basis, I'm not sure this logic should be implemented in KWin itself. Suggestions are welcome. (In reply to Andrey from comment #15) > It will be disabled permanently on Alt+Tab switching, if the windows have > different keyboard layout. > I hoped it will solve major part of the problem, if you don't think so - > please reply, preferably with argumentation. > We will have to think how to do that then, currently I have no ready > solution. > Maybe it should be regulated on theme basis, I'm not sure this logic should > be implemented in KWin itself. > Suggestions are welcome. >I hoped it will solve major part of the problem, Not, it not. I switch language layouts A LOT, seeing an OSD for every change is very bad decision, i already see that layout is changed in applet in tray, why do i need an OSD for action that i perform tens of time per a minute? In windows, for example, i do not see an OSD for layout change when i press ctrl+shift, in x11 plasma there is no OSD too, thankfully, and i happy with it. If you want this OSD very bad, then please, make all OSD configurable (allowing me to disable this one leaving others intant), otherwise i will be forced to disable OSD (i don't want this), A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/279 Git commit 61be205a0dd98bc6a56c34697490a86ad5118231 by Andrey Butirsky. Committed on 01/02/2021 at 13:39. Pushed by butirsky into branch 'master'. feat: add option to disable OSD on keyboard layout change Counterpart commit with the same title is in P-D Related: bug 376460 M +5 -3 shell/osd.cpp M +2 -1 shell/osd.h https://invent.kde.org/plasma/plasma-workspace/commit/61be205a0dd98bc6a56c34697490a86ad5118231 Git commit 86381afb241ac0d3d70947819e8971a14300518a by Andrey Butirsky. Committed on 01/02/2021 at 13:55. Pushed by butirsky into branch 'master'. feat: add option to disable OSD on keyboard layout change Existing ability to disable OSD globally seems is not enough. People see OSD on keyboard layout change especially annoying. So provide the fine grained option. Counterpart commit with the same title is in P-W Related: bug 376460 M +2 -0 kcms/keyboard/CMakeLists.txt M +8 -1 kcms/keyboard/kcm_keyboard.cpp M +2 -0 kcms/keyboard/kcm_keyboard.h M +7 -4 kcms/keyboard/kcm_keyboard.ui M +14 -2 kcms/keyboard/kcm_keyboard_widget.cpp M +4 -1 kcms/keyboard/kcm_keyboard_widget.h A +6 -0 kcms/keyboard/workspace_options.kcfgc M +6 -0 kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg https://invent.kde.org/plasma/plasma-desktop/commit/86381afb241ac0d3d70947819e8971a14300518a |