Bug 426313

Summary:	After reverting changes, apply button keeps being active
Product:	[Applications] systemsettings	Reporter:	postix <postix>
Component:	kcm_formats	Assignee:	Sebastian Kügler <sebas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs, postix, tumaix
Priority:	NOR
Version:	5.19.4
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/32a565bae7e2f7243d2715df56b8617dc8dd3612	Version Fixed In:	5.24
Sentry Crash Report:

Description postix 2020-09-08 19:40:37 UTC

STEPS TO REPRODUCE
1. Go to regional settings -> formats
2. Check "detailed settings"
3. Uncheck it again

OBSERVED RESULT

Apply button stays active


EXPECTED RESULT

If nothing has changed, there's nothing to apply.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0

Comment 1 Nate Graham 2020-09-08 20:45:34 UTC

Needs porting to KConfigXT which is blocked on the QML port being merged: https://phabricator.kde.org/D25449

Comment 2 Nate Graham 2021-10-05 17:20:48 UTC

Git commit 25485ac8d35ec25c1cf1475516016d6f8b93a9f2 by Nate Graham, on behalf of Han Young.
Committed on 05/10/2021 at 17:20.
Pushed by ngraham into branch 'master'.

port formats to qml
Related: bug 279658, bug 338599, bug 362865, bug 389529, bug 410606, bug 422467

FIXED-IN: 5.24

M  +16   -7    kcms/formats/CMakeLists.txt
D  +0    -113  kcms/formats/formats.desktop
M  +46   -326  kcms/formats/kcmformats.cpp
M  +15   -33   kcms/formats/kcmformats.h
D  +0    -385  kcms/formats/kcmformatswidget.ui

https://invent.kde.org/plasma/plasma-workspace/commit/25485ac8d35ec25c1cf1475516016d6f8b93a9f2

Comment 3 Ben Cooksley 2021-10-06 07:45:51 UTC

Git commit 32a565bae7e2f7243d2715df56b8617dc8dd3612 by Ben Cooksley, on behalf of Han Young.
Committed on 06/10/2021 at 07:41.
Pushed by bcooksley into branch 'master'.

kcms/formats: port to QML
Related: bug 279658, bug 338599, bug 362865, bug 389529, bug 410606, bug 422467

FIXED-IN: 5.24

M  +16   -7    kcms/formats/CMakeLists.txt
A  +66   -0    kcms/formats/exampleutility.cpp     [License: GPL(v2.0+)]
D  +0    -113  kcms/formats/formats.desktop
A  +61   -0    kcms/formats/formatssettings.kcfg
A  +6    -0    kcms/formats/formatssettings.kcfgc
M  +46   -326  kcms/formats/kcmformats.cpp
M  +15   -33   kcms/formats/kcmformats.h
D  +0    -385  kcms/formats/kcmformatswidget.ui
A  +176  -0    kcms/formats/localelistmodel.cpp     [License: GPL (v2+)]
A  +58   -0    kcms/formats/localelistmodel.h     [License: GPL (v2+)]
A  +140  -0    kcms/formats/optionsmodel.cpp     [License: GPL(v2.0+)]
A  +32   -0    kcms/formats/optionsmodel.h     [License: GPL(v2.0+)]
A  +126  -0    kcms/formats/package/contents/ui/main.qml     [License: LGPL(v3.0+)]
A  +23   -0    kcms/formats/package/metadata.desktop

https://invent.kde.org/plasma/plasma-workspace/commit/32a565bae7e2f7243d2715df56b8617dc8dd3612