Bug 426199

Summary: frameworks-kglobalaccel build requires X11 on Linux
Product: [Frameworks and Libraries] frameworks-kglobalaccel Reporter: Leonard Lausen <leonard>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: a.samirh78, leonard
Priority: NOR    
Version: 5.73.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.94
Sentry Crash Report:
Attachments: patch

Description Leonard Lausen 2020-09-05 04:28:20 UTC
Created attachment 131426 [details]
patch

kglobalaccel supports building without X11 only on MacOS.

OBSERVED RESULT
Building kglobalaccel for Wayland requires building with X11 too.

EXPECTED RESULT
kglobalaccel can be built without X11 support on Linux.

Attached is a simple patch to add an USE_X11 option to the CmakeLists.txt. There might be a more idiomatic way with ECM, but this sufficed to try build kglobalaccel without X11.
Comment 1 Christoph Feck 2020-09-28 09:47:45 UTC
Please submit patches via our Gitlab instance. For more information, please read https://community.kde.org/Get_Involved/development#Submit_a_Merge_Request