Bug 426100

Summary: Unnecessary inline message after the password dialog to add username to sambashare group is canceled without providing the password
Product: [Frameworks and Libraries] kdenetwork-filesharing Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Harald Sitter <sitter>
Status: RESOLVED FIXED    
Severity: minor CC: nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2020-09-02 14:45:39 UTC
Created attachment 131360 [details]
screenshot

SUMMARY
As we can see in the attached screenshot, "Share" tab shows "Group changes failed." inline message after the password dialog to add username to "sambashare" group to be canceled. In fact group changes did not failed in this case, they just were intentionally canceled.

STEPS TO REPRODUCE
1. start Plasma with a user account not present in "sambashare" group
2. open Dolphin
3. open properties window of a folder and click on "Share" tab
4. click on "Make me a group member" button
5. cancel the password dialog

EXPECTED RESULT
no inline message

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Harald Sitter 2020-09-02 15:23:57 UTC
That's a code shortcut by design. The exact reason for why the transaction wasn't carried out isn't being taken into account as there's a mountain of reasons and mapping them all to unique strings is a waste of time for a dialog people only ever sees once per installation. And at the same time there ought to be some feedback even when the user cancels because the cancelling can happen in all sorts of unobvious ways such as hitting esc randomly.
Comment 2 Patrick Silva 2025-07-16 23:07:25 UTC
Cannot reproduce.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 6.4.80
KDE Frameworks Version: 6.17.0
Qt Version: 6.9.1
Graphics Platform: Wayland