| Summary: | Buttons in toolbar exceed toolbar with Material or Universal style | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahiemstra |
| Priority: | NOR | ||
| Version First Reported In: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/e95f9ecf930ec252023ff7d90fa4f276717a5503 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
Git commit e95f9ecf930ec252023ff7d90fa4f276717a5503 by Arjen Hiemstra. Committed on 03/09/2020 at 10:24. Pushed by ahiemstra into branch 'master'. Add a property to ToolBarLayout to control how to deal with item height By default, items will now be constrained by the toolbar height, with smaller items centered. A property is exposed however that allows controlling the behaviour, setting it either to always match the toolbar height or to never affect item height. M +7 -0 src/controls/ActionToolBar.qml M +28 -1 src/toolbarlayout.cpp M +26 -0 src/toolbarlayout.h M +6 -0 src/toolbarlayoutdelegate.cpp M +1 -0 src/toolbarlayoutdelegate.h https://invent.kde.org/frameworks/kirigami/commit/e95f9ecf930ec252023ff7d90fa4f276717a5503 |
Created attachment 131096 [details] Screenshot With Material or Universal QQC2 style the Toolbuttons have an implicit size larger than the page's toolbar. This results in the buttons exceeding the toolbar. It boils down to 1) the ActionToolbar in the globaltoolbarui not having an explicit size and 2) the ActionToolbar not propagating that explicit size to its delegated. It seems to look properly with qqc2-desktop-style and Plasma by pure chance