| Summary: | effect around indexed paths is triggered again when settings window is maximized | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/4043561f2fffc7965c4fdc5f1d0908a39e6ded84 | Version Fixed/Implemented In: | 21.04 |
| Sentry Crash Report: | |||
| Attachments: | screen recording | ||
I don't know that we even need that effect in the first place, to be honest. Will fix this as a part of my (WIP) work to re-do the config window, which needs https://invent.kde.org/multimedia/elisa/-/merge_requests/183 to be merged first. A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/198 Git commit 4043561f2fffc7965c4fdc5f1d0908a39e6ded84 by Nate Graham. Committed on 10/12/2020 at 15:32. Pushed by ngraham into branch 'master'. Redo configuration window The configuration window is re-done in a modern style. The changes include: - Use Form Layout style - Use standard style list delegates - Use standard Kirigami Units for distances, sizes, and paddings - Use an invokable function to remove paths rather than directly manipulating the model from inside the view - Re-word some text for clarity and brevity - Display warning for using filesystem crawling only when the option is selected - Combine everything into a single file for simplicity - Don't let the user remove the last music search path - Re-order properties to conform to standard style - Use QQC2 import name These changes fix the following bugs: Related: bug 418578 FIXED-IN: 21.04 Note that this bumps the frameworks dependency to 5.77 due to the use of the new trailing property in Kirigami.BasicListItem. M +1 -1 CMakeLists.txt M +0 -2 src/CMakeLists.txt M +6 -0 src/localFileConfiguration/elisaconfigurationdialog.cpp M +3 -0 src/localFileConfiguration/elisaconfigurationdialog.h M +252 -50 src/qml/ElisaConfigurationDialog.qml D +0 -159 src/qml/FileScanningConfiguration.qml D +0 -153 src/qml/GeneralConfiguration.qml M +0 -2 src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/4043561f2fffc7965c4fdc5f1d0908a39e6ded84 |
Created attachment 130726 [details] screen recording SUMMARY Watch the attached screen recording please. EXPECTED RESULT do not trigger the effect around the indexed paths when settings window is maximized SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.73.0 Qt Version: 5.14.2