| Summary: | Line chart Y range max value for system monitor widget is too small | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nicola Mori <nicolamori> |
| Component: | System Monitor widgets | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.20.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/commit/e01caf4fb1bb4245d1f1fdb20cf58a9695037628 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nicola Mori
2020-07-22 07:01:44 UTC
In 5.19.4 and 5.19.5 the automatic Y range seems to somehow set a sane and fixed maximum value. However, the problem with the manual set of the maximum Y value persists. Still present in version 5.20.1. The maximum settable value is 99,999 which for the memory monitor widget corresponds to about 99 MB. Still present in 5.20.2 with frameworks 5.75.0. Git commit 504dcbd225e26fe39f1f26d65ad477fc73558762 by Arjen Hiemstra. Committed on 23/02/2021 at 15:27. Pushed by ahiemstra into branch 'master'. Set min/max for Y axis range spinboxes to minimum/maximum possible value Some sensors have a range of gigabytes or terabytes, like memory and disk. Since the base unit for these is bytes, we end up needing a very large value in the range, which currently is not possible due to the spinbox limiting the value. Internally, spinbox seems to use an int so we can only store a value that fits within the range of an int, so we use that as min/max value. Longer term we want to have some ability to choose an actual "maximum" sensor but that's going to need more work. Related: bug 433007 M +4 -4 faces/facepackages/barchart/contents/ui/Config.qml M +4 -4 faces/facepackages/linechart/contents/ui/Config.qml M +4 -2 faces/facepackages/piechart/contents/ui/Config.qml https://invent.kde.org/plasma/libksysguard/commit/504dcbd225e26fe39f1f26d65ad477fc73558762 Git commit e01caf4fb1bb4245d1f1fdb20cf58a9695037628 by Arjen Hiemstra. Committed on 26/02/2021 at 09:39. Pushed by ahiemstra into branch 'Plasma/5.21'. Set min/max for Y axis range spinboxes to minimum/maximum possible value Some sensors have a range of gigabytes or terabytes, like memory and disk. Since the base unit for these is bytes, we end up needing a very large value in the range, which currently is not possible due to the spinbox limiting the value. Internally, spinbox seems to use an int so we can only store a value that fits within the range of an int, so we use that as min/max value. Longer term we want to have some ability to choose an actual "maximum" sensor but that's going to need more work. Related: bug 433007 (cherry picked from commit 504dcbd225e26fe39f1f26d65ad477fc73558762) M +4 -4 faces/facepackages/barchart/contents/ui/Config.qml M +4 -4 faces/facepackages/linechart/contents/ui/Config.qml M +4 -2 faces/facepackages/piechart/contents/ui/Config.qml https://invent.kde.org/plasma/libksysguard/commit/e01caf4fb1bb4245d1f1fdb20cf58a9695037628 |