| Summary: | Password is asked twice when connecting to a new WiFi network | ||
|---|---|---|---|
| Product: | [Plasma] plasma-nm | Reporter: | popov895 <popov895> |
| Component: | applet | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jgrulich, joey.joey586, nate, popov895 |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.19.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-nm/commit/271332cfc19ede398854113d037abfb35503179f | Version Fixed In: | 5.20 |
| Sentry Crash Report: | |||
| Attachments: |
WiFi connection
journalctl |
||
Password length is 20 chars Created attachment 129443 [details]
journalctl
It appears to be a bug caused by the applet rewrite to ExpandableListItem. No idea how to fix it. @Nate, do you? It appears that in changeState() when using "passwordDialogComponent.password" you don't get the password, because you are accessing a Component (a template), not any instance which actually represents the password field. You need direct access to the Loader to access the initialized password component, which is what we were using before. Yeah, Kai reported this to me. I added support in Frameworks 5.72 to access the loader's item; see https://invent.kde.org/frameworks/plasma-framework/-/commit/7f9e189d87c040a952533713ff48d32872e0eadd Shamefully I haven't actually produced a MR with the fix in plasma-nm though. I started working on it and got stuck and forgot about it, sorry. If you have a quick fix feel free to commit it or send a MR! Since the fix requires a change in plasma-framework, the plasma-nm will have to land in 5.20, and then we can cajole packagers to backport both commits. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/4 Testing and assistance with the above WIP patch would be greatly appreciated. Git commit 271332cfc19ede398854113d037abfb35503179f by Jan Grulich, on behalf of Nate Graham. Committed on 18/06/2020 at 15:34. Pushed by grulich into branch 'master'. [WIP] [applet] Fix inline password field component not working properly FIXED-IN: 5.20 M +2 -2 applet/contents/ui/ConnectionItem.qml https://invent.kde.org/plasma/plasma-nm/commit/271332cfc19ede398854113d037abfb35503179f *** Bug 423168 has been marked as a duplicate of this bug. *** This fix landed in 5.20, but I have asked distro packagers to backport it for 5.19. Will this fix be backported to the KDE neon 5.19? |
Created attachment 129441 [details] WiFi connection SUMMARY Password is asked twice when connecting to a new WiFi network. At first the password is asked in the Network applet and then it's asked again through the system dialog. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE neon 5.19 User Edition KDE Plasma Version: 5.19.1 KDE Frameworks Version: 5.71.0 Qt Version: 5.14.2