| Summary: | Close button of overlaySheet has pixelated icon | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kainz.a, nate, nicolas.fella |
| Priority: | NOR | ||
| Version: | 5.71.0 | ||
| Target Milestone: | Not decided | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/fd6e61386fef38dcf3d4dea58ba8d86c6eb971c9 | Version Fixed In: | 5.72 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot
GHNS window on X11 |
||
Are you using any kind of scaling? (In reply to Nate Graham from comment #1) > Are you using any kind of scaling? No, display scale 100%. Weirdly I can't reproduce anymore. If you also can not, feel free to close this bug. Here's something to test: if you resize the window while the sheet is open, does the button become pixellated and then fix itself and then become pixellated again? (In reply to Nate Graham from comment #3) > Here's something to test: if you resize the window while the sheet is open, > does the button become pixellated and then fix itself and then become > pixellated again? I can't reproduce with your steps, but I have already found the exact ones. This bug only occurs on Wayland when Discover opens not-maximized. open Discover on Wayland if it opens maximized, resize the window by dragging any border and restart Discover now try to reproduce The same steps on X11 results in a non-pixelated but weird icon. "X" looks a bit distorted. Cool. Created attachment 129411 [details]
GHNS window on X11
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/41 Git commit fd6e61386fef38dcf3d4dea58ba8d86c6eb971c9 by Nicolas Fella. Committed on 30/06/2020 at 11:49. Pushed by nicolasfella into branch 'master'. [overlaysheet] Avoid fractional height for contentLayout Earlier in the calculation we are dividing several things by two, which may lead to non-integer results. Setting a non-integer size for contentLayout leads to broken text and icon rendering for child elements. M +2 -2 src/controls/templates/OverlaySheet.qml https://invent.kde.org/frameworks/kirigami/commit/fd6e61386fef38dcf3d4dea58ba8d86c6eb971c9 *** Bug 418033 has been marked as a duplicate of this bug. *** |
Created attachment 129343 [details] screenshot SUMMARY See the attached screenshot please. EXPECTED RESULT crisp icon SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.19.0 KDE Frameworks Version: 5.71.0 Qt Version: 5.15.0